Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: vpython/python/find.go

Issue 2905943002: [vpython] Incorporate interpreter path/hash. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vpython/api/vpython/env.pb.go ('k') | vpython/python/interpreter.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vpython/python/find.go
diff --git a/vpython/python/find.go b/vpython/python/find.go
index 65c62ede0fba69bf302191a76ce57bf9dd8c0c2e..3eb72fbc495f131bcc3eb89fbf037db4ab7f4201 100644
--- a/vpython/python/find.go
+++ b/vpython/python/find.go
@@ -45,10 +45,14 @@ func Find(c context.Context, vers Version) (*Interpreter, error) {
}
i := Interpreter{Python: p}
+ if err := i.Normalize(); err != nil {
+ return nil, err
+ }
+
iv, err := i.GetVersion(c)
if err != nil {
return nil, errors.Annotate(err).Reason("failed to get version for: %(interp)q").
- D("interp", p).
+ D("interp", i.Python).
Err()
}
if vers.IsSatisfiedBy(iv) {
« no previous file with comments | « vpython/api/vpython/env.pb.go ('k') | vpython/python/interpreter.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698