Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2905893002: chromeos: convert more ash/wm code to aura::Window (Closed)

Created:
3 years, 7 months ago by sky
Modified:
3 years, 7 months ago
Reviewers:
varkha
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: convert more ash/wm code to aura::Window BUG=722553 TEST=covered by tests R=varkha@chromium.org Review-Url: https://codereview.chromium.org/2905893002 Cr-Commit-Position: refs/heads/master@{#474757} Committed: https://chromium.googlesource.com/chromium/src/+/cd9d4aeceea0690b9ce7aef8b84d6ed92b7b2f87

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : moar cleanup #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -172 lines) Patch
M ash/frame/caption_buttons/frame_size_button.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/mus/move_event_handler.h View 1 3 chunks +3 lines, -5 lines 0 comments Download
M ash/mus/move_event_handler.cc View 1 6 chunks +20 lines, -21 lines 0 comments Download
M ash/mus/window_manager.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ash/wm/panels/panel_window_event_handler.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M ash/wm/toplevel_window_event_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/wm/toplevel_window_event_handler.cc View 1 3 chunks +3 lines, -5 lines 0 comments Download
M ash/wm/window_util.h View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M ash/wm/window_util.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M ash/wm/wm_toplevel_window_event_handler.h View 4 chunks +13 lines, -12 lines 0 comments Download
M ash/wm/wm_toplevel_window_event_handler.cc View 1 2 18 chunks +72 lines, -45 lines 1 comment Download
M ash/wm/workspace/multi_window_resize_controller.cc View 1 2 3 chunks +3 lines, -9 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler.h View 2 chunks +6 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler.cc View 1 2 7 chunks +11 lines, -12 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler_aura.cc View 1 chunk +2 lines, -2 lines 2 comments Download
M ash/wm_window.h View 2 chunks +0 lines, -11 lines 0 comments Download
M ash/wm_window.cc View 1 6 chunks +4 lines, -36 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
sky
3 years, 7 months ago (2017-05-25 17:21:41 UTC) #3
varkha
https://codereview.chromium.org/2905893002/diff/40001/ash/wm/wm_toplevel_window_event_handler.cc File ash/wm/wm_toplevel_window_event_handler.cc (right): https://codereview.chromium.org/2905893002/diff/40001/ash/wm/wm_toplevel_window_event_handler.cc#newcode531 ash/wm/wm_toplevel_window_event_handler.cc:531: wm::WindowState* window_state = GetWindowState(window); nit: Do you need wm:: ...
3 years, 7 months ago (2017-05-25 19:11:52 UTC) #8
sky
https://codereview.chromium.org/2905893002/diff/40001/ash/wm/workspace/workspace_event_handler_aura.cc File ash/wm/workspace/workspace_event_handler_aura.cc (right): https://codereview.chromium.org/2905893002/diff/40001/ash/wm/workspace/workspace_event_handler_aura.cc#newcode13 ash/wm/workspace/workspace_event_handler_aura.cc:13: WorkspaceEventHandlerAura::WorkspaceEventHandlerAura(WmWindow* workspace_window) On 2017/05/25 19:11:52, varkha wrote: > Is ...
3 years, 7 months ago (2017-05-25 19:26:06 UTC) #9
varkha
lgtm
3 years, 7 months ago (2017-05-25 19:29:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905893002/40001
3 years, 7 months ago (2017-05-25 19:33:06 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 19:38:49 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cd9d4aeceea0690b9ce7aef8b84d...

Powered by Google App Engine
This is Rietveld 408576698