Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 2905843002: Fix build with system harfbuzz (Closed)

Created:
3 years, 7 months ago by Paweł Hajdan Jr.
Modified:
3 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build with system harfbuzz This updates the unbundle file to get back in sync with mainline. This is similar to recently landed https://codereview.chromium.org/2808383006 and https://codereview.chromium.org/2888783003 . This does not affect any build at Google. build/linux/unbundle is a completely parallel directory tree intended to be used by Linux distribution packagers. Please see https://cs.chromium.org/chromium/src/build/linux/unbundle/README for more context. BUG=none R=thestig@chromium.org Review-Url: https://codereview.chromium.org/2905843002 . Cr-Commit-Position: refs/heads/master@{#474730} Committed: https://chromium.googlesource.com/chromium/src/+/db97ed5e204be540ce90807b526324fd8ae4531a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M build/linux/unbundle/harfbuzz-ng.gn View 1 chunk +15 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paweł Hajdan Jr.
3 years, 7 months ago (2017-05-25 13:07:36 UTC) #2
Lei Zhang
lgtm
3 years, 7 months ago (2017-05-25 18:35:41 UTC) #3
Paweł Hajdan Jr.
3 years, 7 months ago (2017-05-25 18:54:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
db97ed5e204be540ce90807b526324fd8ae4531a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698