Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2888783003: Fix build with system libpng (Closed)

Created:
3 years, 7 months ago by Paweł Hajdan Jr.
Modified:
3 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build with system libpng This updates the unbundle file to get back in sync with mainline, so that targets that depend on libpng_config continue to work. This is similar to recently landed https://codereview.chromium.org/2808383006 . This does not affect any build at Google. build/linux/unbundle is a completely parallel directory tree intended to be used by Linux distribution packagers. Please see https://cs.chromium.org/chromium/src/build/linux/unbundle/README for more context. BUG=none R=thestig@chromium.org Review-Url: https://codereview.chromium.org/2888783003 . Cr-Commit-Position: refs/heads/master@{#472530} Committed: https://chromium.googlesource.com/chromium/src/+/fe19263cfa7e714a402a3ed9ed59d304a3da8162

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/linux/unbundle/libpng.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paweł Hajdan Jr.
3 years, 7 months ago (2017-05-17 16:13:53 UTC) #2
Lei Zhang
lgtm
3 years, 7 months ago (2017-05-17 18:27:16 UTC) #3
Paweł Hajdan Jr.
3 years, 7 months ago (2017-05-17 19:28:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fe19263cfa7e714a402a3ed9ed59d304a3da8162 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698