Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 2905773003: [Mac] Mirror bookmark bubble in RTL (Closed)

Created:
3 years, 7 months ago by lgrey
Modified:
3 years, 7 months ago
Reviewers:
Elly Fong-Jones
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Mirror bookmark bubble in RTL BUG=726398 Review-Url: https://codereview.chromium.org/2905773003 Cr-Commit-Position: refs/heads/master@{#475006} Committed: https://chromium.googlesource.com/chromium/src/+/83b898248b21bd35c368e2a23b71322e67f74a8d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M chrome/app/nibs/BookmarkBubble.xib View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm View 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
lgrey
PTAL :) I'd really rather kill this NIB, but the effort/reward ratio isn't great IMO. ...
3 years, 7 months ago (2017-05-25 18:02:14 UTC) #2
Elly Fong-Jones
lgtm
3 years, 7 months ago (2017-05-26 15:00:50 UTC) #3
lgrey
Thanks!
3 years, 7 months ago (2017-05-26 15:01:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905773003/1
3 years, 7 months ago (2017-05-26 15:02:16 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 15:23:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/83b898248b21bd35c368e2a23b71...

Powered by Google App Engine
This is Rietveld 408576698