Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issue 2905683002: PPC/s390: Fix to use correct instr to test bit (Closed)

Created:
3 years, 7 months ago by JaideepBajwa
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: Fix to use correct instr to test bit R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2905683002 Cr-Commit-Position: refs/heads/master@{#45523} Committed: https://chromium.googlesource.com/v8/v8/+/2d3f1082f3d8fb0a4284b1f21ca4888c9b2bf39b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 3 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 7 months ago (2017-05-24 17:58:07 UTC) #1
john.yan
lgtm
3 years, 7 months ago (2017-05-24 18:15:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905683002/1
3 years, 7 months ago (2017-05-24 18:16:45 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 18:48:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2d3f1082f3d8fb0a4284b1f21ca4888c9b2...

Powered by Google App Engine
This is Rietveld 408576698