Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: src/builtins/s390/builtins-s390.cc

Issue 2905683002: PPC/s390: Fix to use correct instr to test bit (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/ppc/builtins-ppc.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/s390/builtins-s390.cc
diff --git a/src/builtins/s390/builtins-s390.cc b/src/builtins/s390/builtins-s390.cc
index e002abca80f97c49fbbe9ba10e8c33f975e2d6d3..2148f11105368fa7f42a01091243ca75d938e3c8 100644
--- a/src/builtins/s390/builtins-s390.cc
+++ b/src/builtins/s390/builtins-s390.cc
@@ -735,10 +735,8 @@ void Builtins::Generate_ResumeGeneratorTrampoline(MacroAssembler* masm) {
// Store input value into generator object.
Label async_await, done_store_input;
- __ AndP(r5, r5,
- Operand(static_cast<int>(SuspendFlags::kAsyncGeneratorAwait)));
- __ CmpP(r5, Operand(static_cast<int>(SuspendFlags::kAsyncGeneratorAwait)));
- __ beq(&async_await);
+ __ tmll(r5, Operand(static_cast<int>(SuspendFlags::kAsyncGeneratorAwait)));
+ __ b(Condition(1), &async_await);
__ StoreP(r2, FieldMemOperand(r3, JSGeneratorObject::kInputOrDebugPosOffset),
r0);
@@ -1205,9 +1203,9 @@ void Builtins::Generate_InterpreterEntryTrampoline(MacroAssembler* masm) {
Label gotta_call_runtime;
// Check if the optimized code is marked for deopt.
- __ LoadlB(r7, FieldMemOperand(optimized_code_entry,
+ __ LoadlW(r7, FieldMemOperand(optimized_code_entry,
Code::kKindSpecificFlags1Offset));
- __ tmll(r7, Operand(Code::kMarkedForDeoptimizationBit));
+ __ And(r0, r7, Operand(1 << Code::kMarkedForDeoptimizationBit));
__ bne(&gotta_call_runtime);
// Optimized code is good, get it into the closure and link the closure into
@@ -1481,8 +1479,8 @@ void Builtins::Generate_CompileLazy(MacroAssembler* masm) {
// Found code, check if it is marked for deopt, if so call into runtime to
// clear the optimized code slot.
- __ LoadlB(r7, FieldMemOperand(entry, Code::kKindSpecificFlags1Offset));
- __ tmll(r7, Operand(Code::kMarkedForDeoptimizationBit));
+ __ LoadlW(r7, FieldMemOperand(entry, Code::kKindSpecificFlags1Offset));
+ __ And(r0, r7, Operand(1 << Code::kMarkedForDeoptimizationBit));
__ bne(&gotta_call_runtime);
// Code is good, get it into the closure and tail call.
« no previous file with comments | « src/builtins/ppc/builtins-ppc.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698