[inspector] Prepare some methods in V8InspectorImpl to multiple sessions

[inspector] Prepare some methods in V8InspectorImpl to multiple sessions

- introduced session id, which fixes an issue of reconnect while evaluating;
- forEachContext provides a safe way to iterate over contexts in a group.

BUG=chromium:590878
Review-Url: https://codereview.chromium.org/2905543004
Cr-Commit-Position: refs/heads/master@{#45613}
Committed: https://chromium.googlesource.com/v8/v8/+/3655dc52b2f9c76c46a28a567ad5176c5d89612d

[dgozman, 2017-05-24 21:46:14]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 21:46:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 22:15:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 22:15:16]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-05-26 19:38:29]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 19:38:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 19:52:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 19:52:05]

Dry run: Try jobs failed on following builders:
  v8_node_linux64_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_node_linux64_rel/builds/...)

[dgozman, 2017-05-26 21:36:42]

dgozman@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[dgozman, 2017-05-26 21:36:43]

Alexei, could you please take a look?

[kozy, 2017-05-30 10:03:45]

lgtm

https://codereview.chromium.org/2905543004/diff/20001/src/inspector/v8-inspec...
File src/inspector/v8-inspector-impl.h (right):

https://codereview.chromium.org/2905543004/diff/20001/src/inspector/v8-inspec...
src/inspector/v8-inspector-impl.h:130: protocol::HashMap<int,
std::unique_ptr<ContextByIdMap>>;
Can we just store protocol::HashMap by value here instead of std::unique_ptr?

https://codereview.chromium.org/2905543004/diff/20001/src/inspector/v8-inspec...
File src/inspector/v8-inspector-session-impl.cc (right):

https://codereview.chromium.org/2905543004/diff/20001/src/inspector/v8-inspec...
src/inspector/v8-inspector-session-impl.cc:292: m_contextGroupId,
[&enabled](InspectedContext* context) {
maybe pass primitive values by value instead of reference? I didn't find any
note on cpp chromium about reference vs value but it looks safer to me.

[dgozman, 2017-05-30 18:08:04]

Thank you for review!

https://codereview.chromium.org/2905543004/diff/20001/src/inspector/v8-inspec...
File src/inspector/v8-inspector-impl.h (right):

https://codereview.chromium.org/2905543004/diff/20001/src/inspector/v8-inspec...
src/inspector/v8-inspector-impl.h:130: protocol::HashMap<int,
std::unique_ptr<ContextByIdMap>>;
On 2017/05/30 10:03:45, kozy wrote:
> Can we just store protocol::HashMap by value here instead of std::unique_ptr?

Probably, I'll work on follow-up refactoring.

https://codereview.chromium.org/2905543004/diff/20001/src/inspector/v8-inspec...
File src/inspector/v8-inspector-session-impl.cc (right):

https://codereview.chromium.org/2905543004/diff/20001/src/inspector/v8-inspec...
src/inspector/v8-inspector-session-impl.cc:292: m_contextGroupId,
[&enabled](InspectedContext* context) {
On 2017/05/30 10:03:45, kozy wrote:
> maybe pass primitive values by value instead of reference? I didn't find any
> note on cpp chromium about reference vs value but it looks safer to me.

So far, I've only seen references being used (but I didn't do an extensive
search). I will try in next patch.

[dgozman, 2017-05-30 18:08:09]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2017-05-30 18:08:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 19:14:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 19:14:32]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/26714)
  v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux64_verify_csa_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_nodcheck_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng_tr...)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)
  v8_linux_verify_csa_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng_...)

[dgozman, 2017-05-30 21:59:16]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-05-30 21:59:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org
Link to the patchset: https://codereview.chromium.org/2905543004/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2017-05-30 21:59:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 00:07:56]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496181556221840,
"parent_rev": "d41fe9f5927edc9a164e19f09d960bf81b4a1102", "commit_rev":
"3655dc52b2f9c76c46a28a567ad5176c5d89612d"}

[commit-bot: I haz the power, 2017-05-31 00:08:03]

Description was changed from

==========
[inspector] Prepare some methods in V8InspectorImpl to multiple sessions

- introduced session id, which fixes an issue of reconnect while evaluating;
- forEachContext provides a safe way to iterate over contexts in a group.

BUG=chromium:590878
==========

to

==========
[inspector] Prepare some methods in V8InspectorImpl to multiple sessions

- introduced session id, which fixes an issue of reconnect while evaluating;
- forEachContext provides a safe way to iterate over contexts in a group.

BUG=chromium:590878

Review-Url: https://codereview.chromium.org/2905543004
Cr-Commit-Position: refs/heads/master@{#45613}
Committed:
https://chromium.googlesource.com/v8/v8/+/3655dc52b2f9c76c46a28a567ad5176c5d8...
==========

[commit-bot: I haz the power, 2017-05-31 00:08:04]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/3655dc52b2f9c76c46a28a567ad5176c5d8...