Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2896303004: [inspector] Move SetIdle from CPUProfiler to debug-interface (Closed)

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 6 months ago
Reviewers:
alph, jgruber
CC:
v8-reviews_googlegroups.com, Yang, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] Move SetIdle from CPUProfiler to debug-interface Idleness is a per-isolate state and should be communicated once, not for every CPUProfiler instance. BUG=none

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -35 lines) Patch
M src/api.cc View 1 2 chunks +13 lines, -8 lines 0 comments Download
M src/debug/debug-interface.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/inspector/v8-inspector-impl.cc View 1 chunk +2 lines, -10 lines 0 comments Download
M src/inspector/v8-profiler-agent-impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/inspector/v8-profiler-agent-impl.cc View 1 2 chunks +0 lines, -13 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
dgozman
Could you please take a look?
3 years, 7 months ago (2017-05-24 22:48:11 UTC) #2
alph
lgtm
3 years, 7 months ago (2017-05-25 22:20:30 UTC) #3
dgozman
Jakob, could you please take a look?
3 years, 7 months ago (2017-05-26 19:39:33 UTC) #4
jgruber
lgtm Sorry for the delay, I was out of town during holidays.
3 years, 6 months ago (2017-05-29 07:45:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896303004/20001
3 years, 6 months ago (2017-05-31 00:09:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/26713) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 6 months ago (2017-05-31 01:16:23 UTC) #10
dgozman
3 years, 6 months ago (2017-05-31 18:56:03 UTC) #11
For some reason, this fails due to DCHECK - we are calling SetIdle while VMState
is JS. Reproduces consistently, I will take a look later. For now, postponing
the patch.

Powered by Google App Engine
This is Rietveld 408576698