Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 2905513003: cocoa: move FRE search bubble up a bit (Closed)

Created:
3 years, 7 months ago by Elly Fong-Jones
Modified:
3 years, 7 months ago
Reviewers:
lgrey, Nico
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cocoa: move FRE search bubble up a bit The arrow is supposed to point just below the magnifying glass, not below the location bar itself. BUG=725641 Review-Url: https://codereview.chromium.org/2905513003 Cr-Commit-Position: refs/heads/master@{#474323} Committed: https://chromium.googlesource.com/chromium/src/+/14502d2f4d4cb396b959f824aab00b62f294bd3b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Elly Fong-Jones
lgrey: ptal? :)
3 years, 7 months ago (2017-05-24 14:08:29 UTC) #3
lgrey
lgtm (but note that I'm not yet a committer)
3 years, 7 months ago (2017-05-24 14:57:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905513003/1
3 years, 7 months ago (2017-05-24 14:58:53 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-24 14:58:55 UTC) #8
Elly Fong-Jones
r=thakis for committer review :)
3 years, 7 months ago (2017-05-24 15:14:20 UTC) #10
Nico
lgtm
3 years, 7 months ago (2017-05-24 15:23:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905513003/1
3 years, 7 months ago (2017-05-24 16:18:32 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 16:40:05 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/14502d2f4d4cb396b959f824aab0...

Powered by Google App Engine
This is Rietveld 408576698