cocoa: move FRE search bubble up a bit

chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
 
 #include "base/bind.h"
 #import "base/mac/mac_util.h"
 #include "base/memory/ptr_util.h"
 #include "base/stl_util.h"
@@ skipping 59 matching lines @@
 #include "ui/gfx/color_utils.h"
 #include "ui/gfx/image/image.h"
 #include "ui/gfx/image/image_skia_util_mac.h"
 #include "ui/gfx/paint_vector_icon.h"
 #include "ui/vector_icons/vector_icons.h"
 
 using content::WebContents;
 
 namespace {
 
-// Vertical space between the bottom edge of the location_bar and the first run
-// bubble arrow point.
-const static int kFirstRunBubbleYOffset = 1;
-
 const int kDefaultIconSize = 16;
 
 // The minimum width the URL should have for the verbose state to be shown.
 const int kMinURLWidth = 120;
 
 // Color of the vector graphic icons when the location bar is dark.
 // SkColorSetARGB(0xCC, 0xFF, 0xFF 0xFF);
 const SkColor kMaterialDarkVectorIconColor = SK_ColorWHITE;
 
 }  // namespace
@@ skipping 555 matching lines @@
   bool icons_updated = false;
   for (const auto& decoration : content_setting_decorations_)
     icons_updated |= decoration->UpdateFromWebContents(web_contents);
   return icons_updated;
 }
 
 void LocationBarViewMac::ShowFirstRunBubbleInternal() {
   if (!field_ || ![field_ window])
     return;
 
-  // Point the bubble's arrow at the middle of the bottom of the page info icon.
-  const NSPoint kOffset =
-      NSMakePoint(info_bubble::kBubbleArrowXOffset, kFirstRunBubbleYOffset);
+  // Point the bubble's arrow at the middle of the page info icon. The x offset
+  // isn't the exact center, but this behavior matches other platforms and it
+  // looks better in practice since the arrow ends up between the handle and
+  // lens of the magnifying glass.
+  const NSPoint kOffset = NSMakePoint(
+      info_bubble::kBubbleArrowXOffset,
+      NSHeight([field_ frame]) / 2.0 - info_bubble::kBubbleArrowHeight);
   [FirstRunBubbleController showForView:field_
                                  offset:kOffset
                                 browser:browser_
                                 profile:profile()];
 }
 
 void LocationBarViewMac::UpdateTranslateDecoration() {
   if (!TranslateService::IsTranslateBubbleEnabled())
     return;
 
@@ skipping 132 matching lines @@
     OnDecorationsChanged();
 }
 
 std::vector<NSView*> LocationBarViewMac::GetDecorationAccessibilityViews() {
   std::vector<LocationBarDecoration*> decorations = GetDecorations();
   std::vector<NSView*> views;
   for (auto* decoration : decorations)
     views.push_back(decoration->GetAccessibilityView());
   return views;
 }