Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2905313002: Revert of Send FrameSwapMessageQueue's messages in QueueMessageSwapPromise (Closed)

Created:
3 years, 7 months ago by Saman Sami
Modified:
3 years, 7 months ago
Reviewers:
Fady Samuel, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Send FrameSwapMessageQueue's messages in QueueMessageSwapPromise (patchset #5 id:100001 of https://codereview.chromium.org/2899073006/ ) Reason for revert: This patch might break SynchronousCompositorFrameSink's delivery of frame swap messages on Android WebView. Original issue's description: > Send FrameSwapMessageQueue's messages in QueueMessageSwapPromise > > In order to simplify RendererCompositorFrameSink and make it more similar > to ClientCompositorFrameSink, it's better to send swap messages in a swap > promise as opposed to in the frame sink. > > BUG=726485 > > Review-Url: https://codereview.chromium.org/2899073006 > Cr-Commit-Position: refs/heads/master@{#474865} > Committed: https://chromium.googlesource.com/chromium/src/+/d235f28c7dfeb0351a6b1e214e62d85f57f2a8c6 TBR=fsamuel@chromium.org,piman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=726485 Review-Url: https://codereview.chromium.org/2905313002 Cr-Commit-Position: refs/heads/master@{#475038} Committed: https://chromium.googlesource.com/chromium/src/+/3c9b43f529531ba78a9b528e292d92186e021aeb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -68 lines) Patch
M content/renderer/gpu/frame_swap_message_queue.h View 3 chunks +1 line, -4 lines 0 comments Download
M content/renderer/gpu/frame_swap_message_queue.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/gpu/frame_swap_message_queue_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/queue_message_swap_promise.cc View 2 chunks +1 line, -16 lines 0 comments Download
M content/renderer/gpu/queue_message_swap_promise_unittest.cc View 12 chunks +14 lines, -42 lines 0 comments Download
M content/renderer/gpu/renderer_compositor_frame_sink.cc View 1 chunk +19 lines, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Saman Sami
Created Revert of Send FrameSwapMessageQueue's messages in QueueMessageSwapPromise
3 years, 7 months ago (2017-05-26 17:15:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905313002/1
3 years, 7 months ago (2017-05-26 17:15:53 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 17:16:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3c9b43f529531ba78a9b528e292d...

Powered by Google App Engine
This is Rietveld 408576698