Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2899073006: Send FrameSwapMessageQueue's messages in QueueMessageSwapPromise (Closed)

Created:
3 years, 7 months ago by Saman Sami
Modified:
3 years, 7 months ago
Reviewers:
Fady Samuel, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Send FrameSwapMessageQueue's messages in QueueMessageSwapPromise In order to simplify RendererCompositorFrameSink and make it more similar to ClientCompositorFrameSink, it's better to send swap messages in a swap promise as opposed to in the frame sink. BUG=726485 Review-Url: https://codereview.chromium.org/2899073006 Cr-Commit-Position: refs/heads/master@{#474865} Committed: https://chromium.googlesource.com/chromium/src/+/d235f28c7dfeb0351a6b1e214e62d85f57f2a8c6

Patch Set 1 #

Total comments: 4

Patch Set 2 : c #

Patch Set 3 : c #

Patch Set 4 : c #

Patch Set 5 : Fixed memory leak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -40 lines) Patch
M content/renderer/gpu/frame_swap_message_queue.h View 1 2 3 3 chunks +4 lines, -1 line 0 comments Download
M content/renderer/gpu/frame_swap_message_queue.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/gpu/frame_swap_message_queue_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/queue_message_swap_promise.cc View 2 chunks +16 lines, -1 line 0 comments Download
M content/renderer/gpu/queue_message_swap_promise_unittest.cc View 1 2 3 4 12 chunks +42 lines, -14 lines 0 comments Download
M content/renderer/gpu/renderer_compositor_frame_sink.cc View 1 chunk +1 line, -19 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 34 (28 generated)
Fady Samuel
looks good once bots are happy. https://codereview.chromium.org/2899073006/diff/1/content/renderer/gpu/frame_swap_message_queue.h File content/renderer/gpu/frame_swap_message_queue.h (right): https://codereview.chromium.org/2899073006/diff/1/content/renderer/gpu/frame_swap_message_queue.h#newcode40 content/renderer/gpu/frame_swap_message_queue.h:40: FrameSwapMessageQueue(int32_t routing_id); explicit ...
3 years, 7 months ago (2017-05-24 21:23:30 UTC) #6
Saman Sami
piman please take a look. https://codereview.chromium.org/2899073006/diff/1/content/renderer/gpu/frame_swap_message_queue.h File content/renderer/gpu/frame_swap_message_queue.h (right): https://codereview.chromium.org/2899073006/diff/1/content/renderer/gpu/frame_swap_message_queue.h#newcode40 content/renderer/gpu/frame_swap_message_queue.h:40: FrameSwapMessageQueue(int32_t routing_id); On 2017/05/24 ...
3 years, 7 months ago (2017-05-25 20:34:37 UTC) #22
piman
lgtm
3 years, 7 months ago (2017-05-25 21:11:06 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899073006/100001
3 years, 7 months ago (2017-05-25 21:29:46 UTC) #30
commit-bot: I haz the power
Committed patchset #5 (id:100001) as https://chromium.googlesource.com/chromium/src/+/d235f28c7dfeb0351a6b1e214e62d85f57f2a8c6
3 years, 7 months ago (2017-05-26 01:24:04 UTC) #33
Saman Sami
3 years, 7 months ago (2017-05-26 17:15:30 UTC) #34
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:100001) has been created in
https://codereview.chromium.org/2905313002/ by samans@chromium.org.

The reason for reverting is: This patch might break
SynchronousCompositorFrameSink's delivery of frame swap messages on Android
WebView..

Powered by Google App Engine
This is Rietveld 408576698