Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2905273002: Photo Picker dialog: Request Storage permission if not already granted (e.g. through downloads). (Closed)

Created:
3 years, 6 months ago by Finnur
Modified:
3 years, 6 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Photo Picker dialog: Request Storage permission if not already granted (e.g. through downloads). BUG=656015 Review-Url: https://codereview.chromium.org/2905273002 Cr-Commit-Position: refs/heads/master@{#475474} Committed: https://chromium.googlesource.com/chromium/src/+/88d2323b8f77429aba663b9cd1f1d1930bb5c948

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address feedback from Ted #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M ui/android/java/src/org/chromium/ui/UiUtils.java View 1 1 chunk +7 lines, -0 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
Finnur
Mind taking this as well?
3 years, 6 months ago (2017-05-26 15:40:10 UTC) #4
Ted C
https://codereview.chromium.org/2905273002/diff/1/ui/android/java/src/org/chromium/ui/UiUtils.java File ui/android/java/src/org/chromium/ui/UiUtils.java (right): https://codereview.chromium.org/2905273002/diff/1/ui/android/java/src/org/chromium/ui/UiUtils.java#newcode83 ui/android/java/src/org/chromium/ui/UiUtils.java:83: boolean shouldShowPhotoPicker(); this doesn't seem to be used.
3 years, 6 months ago (2017-05-26 19:22:16 UTC) #7
Finnur
Indeed. Addressed, PTAL.
3 years, 6 months ago (2017-05-29 09:35:03 UTC) #10
Finnur
Friendly ping. I know you are busy, but if you have the time to take ...
3 years, 6 months ago (2017-05-30 00:19:52 UTC) #13
Ted C
On 2017/05/30 00:19:52, Finnur wrote: > Friendly ping. I know you are busy, but if ...
3 years, 6 months ago (2017-05-30 04:11:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905273002/20001
3 years, 6 months ago (2017-05-30 09:01:49 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/88d2323b8f77429aba663b9cd1f1d1930bb5c948
3 years, 6 months ago (2017-05-30 09:06:39 UTC) #19
Finnur
3 years, 6 months ago (2017-05-30 11:14:50 UTC) #20
Message was sent while issue was closed.
> The US had of monday, so it wasn't due to business, but we weren't working
today

Ah, a slacker! I knew it! 

Just kidding. :) I had forgotten about Memorial Day. Thanks for the reviews!

Powered by Google App Engine
This is Rietveld 408576698