Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java

Issue 2905273002: Photo Picker dialog: Request Storage permission if not already granted (e.g. through downloads). (Closed)
Patch Set: Address feedback from Ted Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/android/java/src/org/chromium/ui/UiUtils.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
diff --git a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java b/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
index 753a559340d994f64956f794b4dcb295ea7ed12a..01bc4cd08b3d481022ec3b2f84391319666bf2c6 100644
--- a/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
+++ b/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
@@ -157,6 +157,10 @@ public class SelectFileDialog implements WindowAndroid.IntentCallback,
&& !window.hasPermission(Manifest.permission.RECORD_AUDIO)) {
missingPermissions.add(Manifest.permission.RECORD_AUDIO);
}
+ if (UiUtils.shouldShowPhotoPicker()
+ && !window.hasPermission(Manifest.permission.READ_EXTERNAL_STORAGE)) {
+ missingPermissions.add(Manifest.permission.READ_EXTERNAL_STORAGE);
+ }
if (missingPermissions.isEmpty()) {
launchSelectFileIntent();
« no previous file with comments | « ui/android/java/src/org/chromium/ui/UiUtils.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698