[DMC #15] Add TextMatchMarkerListImpl::SetTextMatchMarkersActive()

Add TextMatchMarkerListImpl::SetTextMatchMarkersActive()

Adding this helper method allows us to simplify the implementation of
DocumentMarkerController::SetTextMatchMarkersActive(), which was previously
depending on details of the implementation of TextMatchMarkerListImpl (whether
or not it stores its markers in sorted order).

BUG=707867
Review-Url: https://codereview.chromium.org/2904973003
Cr-Commit-Position: refs/heads/master@{#474914}
Committed: https://chromium.googlesource.com/chromium/src/+/f04ef6cf643d773e4176cbc4142251b18e959b7f

[rlanday, 2017-05-24 23:01:58]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 23:02:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-05-24 23:02:36]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[commit-bot: I haz the power, 2017-05-25 02:59:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 02:59:34]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[yosin_UTC9, 2017-05-25 05:25:39]

https://codereview.chromium.org/2904973003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.cpp
(right):

https://codereview.chromium.org/2904973003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.cpp:89:
const auto start_pos = std::upper_bound(
nit: s/start_pos/start/

Blink doesn't like abbreviation and it is an iterator instead of a position.
In core/editing, position usually means |Position|.

https://codereview.chromium.org/2904973003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.cpp:94:
for (auto marker = start_pos; marker != markers_.end(); ++marker) {
|marker| is an iterator instead of |DocumentMarker|.
We could write

for (auto it = start; it != markers_.end(); ++it) {
  Marker& it = **it;
  ...

[rlanday, 2017-05-25 07:00:06]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-05-25 07:00:28]

Updated

[commit-bot: I haz the power, 2017-05-25 07:00:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 07:03:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 07:03:05]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rlanday, 2017-05-25 07:05:00]

On 2017/05/25 at 07:00:28, rlanday wrote:
> Updated

(try bots are failing due to patch failure; I will rebase after DMC #13 and #14
land)

[rlanday, 2017-05-25 20:19:56]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-05-25 20:20:04]

On 2017/05/25 at 07:05:00, rlanday wrote:
> On 2017/05/25 at 07:00:28, rlanday wrote:
> > Updated
> 
> (try bots are failing due to patch failure; I will rebase after DMC #13 and
#14 land)

Rebased

[commit-bot: I haz the power, 2017-05-25 20:20:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-25 21:27:34]

lgtm

[commit-bot: I haz the power, 2017-05-26 00:08:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 00:08:13]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-05-26 02:08:33]

lgtm w/ nits

https://codereview.chromium.org/2904973003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.cpp
(right):

https://codereview.chromium.org/2904973003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.cpp:88: 
Please remove an extra blank line.

https://codereview.chromium.org/2904973003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.cpp:100: 
Please remove an extra blank line.

https://codereview.chromium.org/2904973003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.cpp:104: 
Please remove an extra blank line.

[rlanday, 2017-05-26 02:55:26]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-05-26 02:55:26]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org,
xiaochengh@chromium.org
Link to the patchset: https://codereview.chromium.org/2904973003/#ps60001
(title: "Remove blank lines")

[commit-bot: I haz the power, 2017-05-26 02:56:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 05:07:19]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495767326354300,
"parent_rev": "560d24759e7e4cecba4d81d1479e13d6f81314d4", "commit_rev":
"f04ef6cf643d773e4176cbc4142251b18e959b7f"}

[commit-bot: I haz the power, 2017-05-26 05:07:31]

Description was changed from

==========
Add TextMatchMarkerListImpl::SetTextMatchMarkersActive()

Adding this helper method allows us to simplify the implementation of
DocumentMarkerController::SetTextMatchMarkersActive(), which was previously
depending on details of the implementation of TextMatchMarkerListImpl (whether
or not it stores its markers in sorted order).

BUG=707867
==========

to

==========
Add TextMatchMarkerListImpl::SetTextMatchMarkersActive()

Adding this helper method allows us to simplify the implementation of
DocumentMarkerController::SetTextMatchMarkersActive(), which was previously
depending on details of the implementation of TextMatchMarkerListImpl (whether
or not it stores its markers in sorted order).

BUG=707867

Review-Url: https://codereview.chromium.org/2904973003
Cr-Commit-Position: refs/heads/master@{#474914}
Committed:
https://chromium.googlesource.com/chromium/src/+/f04ef6cf643d773e4176cbc41422...
==========

[commit-bot: I haz the power, 2017-05-26 05:07:36]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f04ef6cf643d773e4176cbc41422...