[DMC #15] Add TextMatchMarkerListImpl::SetTextMatchMarkersActive()

third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.cpp

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/markers/TextMatchMarkerListImpl.h"
 
 #include "core/dom/Node.h"
 #include "core/dom/Range.h"
 #include "core/editing/EphemeralRange.h"
 #include "core/editing/markers/DocumentMarkerListEditor.h"
@@ skipping 63 matching lines @@
     if (!rendered_marker->IsValid())
       UpdateMarkerRenderedRect(node, *rendered_marker);
     if (!rendered_marker->IsRendered())
       continue;
     result.push_back(rendered_marker->RenderedRect());
   }
 
   return result;
 }
 
+bool TextMatchMarkerListImpl::SetTextMatchMarkersActive(unsigned start_offset,
+                                                        unsigned end_offset,
+                                                        bool active) {
+  bool doc_dirty = false;
+
+  const auto start_pos = std::upper_bound(

[yosin_UTC9, 2017/05/25 05:25:39]

nit: s/start_pos/start/

Blink doesn't like abbreviation and it is an iterator instead of a position.
In core/editing, position usually means |Position|.

+      markers_.begin(), markers_.end(), start_offset,
+      [](size_t start_offset, const Member<DocumentMarker>& marker) {
+        return start_offset < marker->EndOffset();
+      });
+  for (auto marker = start_pos; marker != markers_.end(); ++marker) {

[yosin_UTC9, 2017/05/25 05:25:39]

|marker| is an iterator instead of |DocumentMarker|.
We could write

for (auto it = start; it != markers_.end(); ++it) {
  Marker& it = **it;
  ...

+    // Markers are returned in order, so stop if we are now past the specified
+    // range.
+    if ((*marker)->StartOffset() >= end_offset)
+      break;
+
+    (*marker)->SetIsActiveMatch(active);
+    doc_dirty = true;
+  }
+
+  return doc_dirty;
+}
+
 }  // namespace blink