Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2904753002: Take and return primitive types by value in ComputedStyle. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
nainar
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Take and return primitive types by value in ComputedStyle. This patch makes accessors for primitive types in ComputedStyleBase receive and return by value instead of by reference. This was the original behaviour, but was accidentally removed during a refactor: https://codereview.chromium.org/2826653002 Diff of generated files: https://gist.github.com/darrnshn/7f90f08d808e6b2790e027b67005e77b/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2904753002 Cr-Commit-Position: refs/heads/master@{#474192} Committed: https://chromium.googlesource.com/chromium/src/+/8f0673bdafc2ad5830b264e64a62f947ca3eef0b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
shend
Hi Naina, PTAL
3 years, 7 months ago (2017-05-23 23:29:24 UTC) #5
nainar
lol sorry about this. lgtm
3 years, 7 months ago (2017-05-23 23:46:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904753002/1
3 years, 7 months ago (2017-05-24 03:01:16 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 07:05:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8f0673bdafc2ad5830b264e64a62...

Powered by Google App Engine
This is Rietveld 408576698