Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Side by Side Diff: third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl

Issue 2904753002: Take and return primitive types by value in ComputedStyle. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 {% macro encode(field, value) %} 1 {% macro encode(field, value) %}
2 {% if field.is_bit_field -%} 2 {% if field.is_bit_field -%}
3 static_cast<unsigned>({{value}}) 3 static_cast<unsigned>({{value}})
4 {%- else -%} 4 {%- else -%}
5 {{value}} 5 {{value}}
6 {%- endif %} 6 {%- endif %}
7 {% endmacro %} 7 {% endmacro %}
8 8
9 {% macro decode(field, value) %} 9 {% macro decode(field, value) %}
10 {% if field.is_bit_field -%} 10 {% if field.is_bit_field -%}
(...skipping 22 matching lines...) Expand all
33 {% macro set_if_changed(field, value) %} 33 {% macro set_if_changed(field, value) %}
34 {% if field.group_member_name -%} 34 {% if field.group_member_name -%}
35 if (!({{getter_expression(field)}} == {{value}})) 35 if (!({{getter_expression(field)}} == {{value}}))
36 {{setter_expression(field)}} = {{value}}; 36 {{setter_expression(field)}} = {{value}};
37 {%- else -%} 37 {%- else -%}
38 {{field.name}} = {{value}}; 38 {{field.name}} = {{value}};
39 {%- endif %} 39 {%- endif %}
40 {% endmacro %} 40 {% endmacro %}
41 41
42 {% macro nonconst_ref(field) %} 42 {% macro nonconst_ref(field) %}
43 {% if field.is_bit_field -%} 43 {% if field.is_bit_field or field.field_template == 'primitive' -%}
44 {{field.type_name}} 44 {{field.type_name}}
45 {%- else -%} 45 {%- else -%}
46 {{field.type_name}}& 46 {{field.type_name}}&
47 {%- endif %} 47 {%- endif %}
48 {% endmacro %} 48 {% endmacro %}
49 49
50 {% macro const_ref(field) %} 50 {% macro const_ref(field) %}
51 {% if field.is_bit_field -%} 51 {% if field.is_bit_field or field.field_template == 'primitive' -%}
52 {{field.type_name}} 52 {{field.type_name}}
53 {%- else -%} 53 {%- else -%}
54 const {{field.type_name}}& 54 const {{field.type_name}}&
55 {%- endif %} 55 {%- endif %}
56 {% endmacro %} 56 {% endmacro %}
57 57
58 {% macro declare_storage(field) %} 58 {% macro declare_storage(field) %}
59 {% if field.is_bit_field %} 59 {% if field.is_bit_field %}
60 unsigned {{field.name}} : {{field.size}}; // {{field.type_name}} 60 unsigned {{field.name}} : {{field.size}}; // {{field.type_name}}
61 {%- else %} 61 {%- else %}
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 {% macro fieldwise_diff(group_to_diff) %} 116 {% macro fieldwise_diff(group_to_diff) %}
117 {% for group in group_to_diff.subgroups %} 117 {% for group in group_to_diff.subgroups %}
118 if ({{group.group_name}}.Get() != other.{{group.group_name}}.Get()) { 118 if ({{group.group_name}}.Get() != other.{{group.group_name}}.Get()) {
119 {{fieldwise_diff(group)|indent(2, true)}} 119 {{fieldwise_diff(group)|indent(2, true)}}
120 } 120 }
121 {% endfor %} 121 {% endfor %}
122 {% for expression in group_to_diff.expressions %} 122 {% for expression in group_to_diff.expressions %}
123 if (self.{{expression}} != other.{{expression}}) 123 if (self.{{expression}} != other.{{expression}})
124 return true; 124 return true;
125 {% endfor %} 125 {% endfor %}
126 {% endmacro %} 126 {% endmacro %}
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698