[Turbofan] Remove TODO to eliminate InstructionOperand::INVALID.

[Turbofan] Remove TODO to eliminate InstructionOperand::INVALID.
- This won't save a bit, since the enum is not a flags enum and there is
  still room for another value.
- While it may be possible to eliminate this value, the code to init
  and check for invalid becomes much more complex. Unallocated operands
  are currently created with invalid vreg code, so we also have to check
  the policy.

BUG=v8:6325
Review-Url: https://codereview.chromium.org/2904603004
Cr-Commit-Position: refs/heads/master@{#45534}
Committed: https://chromium.googlesource.com/v8/v8/+/d81be3b4ac42b85cb0d67543ef56ad3152979c2b

[bbudge, 2017-05-23 23:44:20]

Description was changed from

==========
[Turbofan] Remove TODO to eliminate InstructionOperand::INVALID.
- This won't save a bit, since the enum is not a flags enum and there is
  still room for another value.
- While it may be possible to eliminate this value, the code to init
  and check for invalid becomes much more complex. Unallocated operands
  are currently created with invalid vreg code, so we also have to check
  the policy.

BUG=
==========

to

==========
[Turbofan] Remove TODO to eliminate InstructionOperand::INVALID.
- This won't save a bit, since the enum is not a flags enum and there is
  still room for another value.
- While it may be possible to eliminate this value, the code to init
  and check for invalid becomes much more complex. Unallocated operands
  are currently created with invalid vreg code, so we also have to check
  the policy.

BUG=v8: 6325
==========

[bbudge, 2017-05-23 23:45:02]

bbudge@chromium.org changed reviewers:
+ mtrofin@chromium.org

[bbudge, 2017-05-23 23:49:49]

Description was changed from

==========
[Turbofan] Remove TODO to eliminate InstructionOperand::INVALID.
- This won't save a bit, since the enum is not a flags enum and there is
  still room for another value.
- While it may be possible to eliminate this value, the code to init
  and check for invalid becomes much more complex. Unallocated operands
  are currently created with invalid vreg code, so we also have to check
  the policy.

BUG=v8: 6325
==========

to

==========
[Turbofan] Remove TODO to eliminate InstructionOperand::INVALID.
- This won't save a bit, since the enum is not a flags enum and there is
  still room for another value.
- While it may be possible to eliminate this value, the code to init
  and check for invalid becomes much more complex. Unallocated operands
  are currently created with invalid vreg code, so we also have to check
  the policy.

BUG=v8:6325
==========

[Mircea Trofin, 2017-05-25 18:10:16]

On 2017/05/23 23:45:02, bbudge wrote:

LGTM.

Invalid and unallocated are different concepts.

[bbudge, 2017-05-25 18:29:49]

The CQ bit was checked by bbudge@chromium.org

[commit-bot: I haz the power, 2017-05-25 18:29:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 18:34:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 18:34:27]

Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)

[bbudge, 2017-05-25 18:41:05]

The CQ bit was checked by bbudge@chromium.org

[commit-bot: I haz the power, 2017-05-25 18:41:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 19:00:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495737665824150, "parent_rev":
"5dde8b312bfbdefdfeeb95fa3f3030ebe2b9529d", "commit_rev":
"d81be3b4ac42b85cb0d67543ef56ad3152979c2b"}

[commit-bot: I haz the power, 2017-05-25 19:00:50]

Description was changed from

==========
[Turbofan] Remove TODO to eliminate InstructionOperand::INVALID.
- This won't save a bit, since the enum is not a flags enum and there is
  still room for another value.
- While it may be possible to eliminate this value, the code to init
  and check for invalid becomes much more complex. Unallocated operands
  are currently created with invalid vreg code, so we also have to check
  the policy.

BUG=v8:6325
==========

to

==========
[Turbofan] Remove TODO to eliminate InstructionOperand::INVALID.
- This won't save a bit, since the enum is not a flags enum and there is
  still room for another value.
- While it may be possible to eliminate this value, the code to init
  and check for invalid becomes much more complex. Unallocated operands
  are currently created with invalid vreg code, so we also have to check
  the policy.

BUG=v8:6325

Review-Url: https://codereview.chromium.org/2904603004
Cr-Commit-Position: refs/heads/master@{#45534}
Committed:
https://chromium.googlesource.com/v8/v8/+/d81be3b4ac42b85cb0d67543ef56ad31529...
==========

[commit-bot: I haz the power, 2017-05-25 19:00:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d81be3b4ac42b85cb0d67543ef56ad31529...