src/compiler/instruction.h - Issue 2904603004: [Turbofan] Remove TODO to eliminate InstructionOperand::INVALID.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/instruction.h

Issue 2904603004: [Turbofan] Remove TODO to eliminate InstructionOperand::INVALID. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/instruction.h

diff --git a/src/compiler/instruction.h b/src/compiler/instruction.h

index 05128c6cdf42d22ab993f2f870a17890557b735b..f16f6bcf5bea931dc19f795bd85c3fc79d0a0fdd 100644

--- a/src/compiler/instruction.h

+++ b/src/compiler/instruction.h

@@ -34,8 +34,6 @@ class V8_EXPORT_PRIVATE InstructionOperand {

public:

static const int kInvalidVirtualRegister = -1;

- // TODO(dcarney): recover bit. INVALID can be represented as UNALLOCATED with

- // kInvalidVirtualRegister and some DCHECKS.

enum Kind {

INVALID,

UNALLOCATED,

« no previous file with comments | « no previous file | no next file » | no next file with comments »