Replace "field_type_path" with "include_paths" in CSSProperties.json5.

Replace "field_type_path" with "include_paths" in CSSProperties.json5.

In CSSProperties.json5, to deal with type_names that are defined in
other files, we use the "field_type_path" parameter. For example, if we
wanted to use "Length" as the type_name, we can specify
"field_type_path" as "platform/Length" and the generator will
automatically include "platform/Length.h". We would also deduce that
the type_name is Length. However, this does not cater for type_names
like "Vector<String>", where multiple files need to be included.

This patch generalises "field_type_path" to "include_paths", which is
simply a list of files containing definitions for the types in
type_name. Since "include_paths" can contain multiple files, we can no
longer deduce the type_name, so we have to explicitly specify the
type_name.

BUG=628043
Review-Url: https://codereview.chromium.org/2904483003
Cr-Commit-Position: refs/heads/master@{#474928}
Committed: https://chromium.googlesource.com/chromium/src/+/e076f00974fd76585a9a922d3674144d577271c5

[shend, 2017-05-24 08:11:56]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 08:12:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 12:04:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 12:04:39]

Dry run: This issue passed the CQ dry run.

[shend, 2017-05-24 23:41:32]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 23:42:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-05-24 23:47:20]

Description was changed from

==========
Replace "field_type_path" with "include_paths".

BUG=
==========

to

==========
Replace "field_type_path" with "include_paths" in CSSProperties.json5.

In CSSProperties.json5, to deal with type_names that are defined in
other files, we use the "field_type_path" parameter. For example, if we
wanted to use "Length" as the type_name, we can specify
"field_type_path" as "platform/Length" and the generator will
automatically include "platform/Length.h". We would also deduce that
the type_name is Length. However, this does not cater for type_names
like "Vector<String>", where multiple files need to be included.

This patch generalises "field_type_path" to "include_paths", which is
simply a list of files containing definitions for the types in
type_name. Since "include_paths" can contain multiple files, we can no
longer deduce the type_name, so we have to explicitly specify the
type_name.

BUG=628043
==========

[shend, 2017-05-24 23:49:23]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 23:49:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-05-24 23:49:56]

shend@chromium.org changed reviewers:
+ nainar@chromium.org

[shend, 2017-05-24 23:49:57]

Hi Naina, PTAL

[nainar, 2017-05-25 00:41:38]

lgtm

[commit-bot: I haz the power, 2017-05-25 02:21:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 02:21:12]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[shend, 2017-05-25 08:14:51]

shend@chromium.org changed reviewers:
+ meade@chromium.org

[shend, 2017-05-25 08:14:52]

Hi Eddy, PTAL

[meade_UTC10, 2017-05-26 01:20:19]

lgtm with optional nit

https://codereview.chromium.org/2904483003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/make_computed_style_base.py
(right):

https://codereview.chromium.org/2904483003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_computed_style_base.py:171: return
list(sorted(set(_flatten_list(property_['include_paths'] for property_ in
properties))))
uh, is there a way that the data can be structured so that this can be less
nested?

[shend, 2017-05-26 01:31:37]

On 2017/05/26 at 01:20:19, meade wrote:
> lgtm with optional nit
> 
>
https://codereview.chromium.org/2904483003/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/build/scripts/make_computed_style_base.py
(right):
> 
>
https://codereview.chromium.org/2904483003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/build/scripts/make_computed_style_base.py:171:
return list(sorted(set(_flatten_list(property_['include_paths'] for property_ in
properties))))
> uh, is there a way that the data can be structured so that this can be less
nested?

hmm one less nesting would be like a list that contains all the include paths
for all the fields. At that point, we might as well just hardcode the #includes.

[shend, 2017-05-26 03:31:23]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 03:31:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 05:32:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 05:32:18]

Dry run: This issue passed the CQ dry run.

[shend, 2017-05-26 05:36:26]

The CQ bit was checked by shend@chromium.org

[shend, 2017-05-26 05:36:26]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org,
nainar@chromium.org
Link to the patchset: https://codereview.chromium.org/2904483003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-26 05:37:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 05:42:11]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495776986105000,
"parent_rev": "6952c722b2c48bcc634950d6cbf171083b1fea53", "commit_rev":
"e076f00974fd76585a9a922d3674144d577271c5"}

[commit-bot: I haz the power, 2017-05-26 05:42:27]

Description was changed from

==========
Replace "field_type_path" with "include_paths" in CSSProperties.json5.

In CSSProperties.json5, to deal with type_names that are defined in
other files, we use the "field_type_path" parameter. For example, if we
wanted to use "Length" as the type_name, we can specify
"field_type_path" as "platform/Length" and the generator will
automatically include "platform/Length.h". We would also deduce that
the type_name is Length. However, this does not cater for type_names
like "Vector<String>", where multiple files need to be included.

This patch generalises "field_type_path" to "include_paths", which is
simply a list of files containing definitions for the types in
type_name. Since "include_paths" can contain multiple files, we can no
longer deduce the type_name, so we have to explicitly specify the
type_name.

BUG=628043
==========

to

==========
Replace "field_type_path" with "include_paths" in CSSProperties.json5.

In CSSProperties.json5, to deal with type_names that are defined in
other files, we use the "field_type_path" parameter. For example, if we
wanted to use "Length" as the type_name, we can specify
"field_type_path" as "platform/Length" and the generator will
automatically include "platform/Length.h". We would also deduce that
the type_name is Length. However, this does not cater for type_names
like "Vector<String>", where multiple files need to be included.

This patch generalises "field_type_path" to "include_paths", which is
simply a list of files containing definitions for the types in
type_name. Since "include_paths" can contain multiple files, we can no
longer deduce the type_name, so we have to explicitly specify the
type_name.

BUG=628043

Review-Url: https://codereview.chromium.org/2904483003
Cr-Commit-Position: refs/heads/master@{#474928}
Committed:
https://chromium.googlesource.com/chromium/src/+/e076f00974fd76585a9a922d3674...
==========

[commit-bot: I haz the power, 2017-05-26 05:42:28]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e076f00974fd76585a9a922d3674...