third_party/WebKit/Source/build/scripts/make_css_value_id_mappings.py - Issue 2904483003: Replace "field_type_path" with "include_paths" in CSSProperties.json5.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/make_css_value_id_mappings.py

Issue 2904483003: Replace "field_type_path" with "include_paths" in CSSProperties.json5. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/make_computed_style_base.py ('k') | third_party/WebKit/Source/core/css/CSSProperties.json5 » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/make_css_value_id_mappings.py

diff --git a/third_party/WebKit/Source/build/scripts/make_css_value_id_mappings.py b/third_party/WebKit/Source/build/scripts/make_css_value_id_mappings.py

index 1809ec0e94b3b75a08addc9ea80326568d983160..8394727d702d01f727764c0e1d47011be4affc21 100755

--- a/third_party/WebKit/Source/build/scripts/make_css_value_id_mappings.py

+++ b/third_party/WebKit/Source/build/scripts/make_css_value_id_mappings.py

@@ -20,16 +20,12 @@ class CSSValueIDMappingsWriter(make_style_builder.StyleBuilderWriter):

@template_expander.use_jinja('CSSValueIDMappingsGenerated.h.tmpl')

def generate_css_value_mappings(self):

mappings = {}

- include_paths = []

+ include_paths = set()

for property_ in self._properties.values():

if property_['field_template'] == 'keyword':

- if property_['field_type_path']:

- type_name = property_['field_type_path'].split('/')[-1]

- include_paths.append(property_['field_type_path'] + '.h')

- else:

- type_name = property_['type_name']

+ include_paths.update(property_['include_paths'])

- mappings[type_name] = {

+ mappings[property_['type_name']] = {

'default_value': enum_value_name(property_['default_value']),

'mapping': [(enum_value_name(k), enum_for_css_keyword(k)) for k in property_['keywords']],

}