Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: extensions/browser/app_window/BUILD.gn

Issue 2904443004: Allow generation of a chromium outdirs when enable_extensions=false (Closed)
Patch Set: Assert enable_extensions: common/BUILD.gn and features/BUILD.gn are marked TODO(crbug.com/731689) Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/app_window/BUILD.gn
diff --git a/extensions/browser/app_window/BUILD.gn b/extensions/browser/app_window/BUILD.gn
index d903645c23152588ad03ebb755b09cb2987979e0..582f915f85634b8baff0417ede8f9b977d547c3c 100644
--- a/extensions/browser/app_window/BUILD.gn
+++ b/extensions/browser/app_window/BUILD.gn
@@ -2,6 +2,11 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//extensions/features/features.gni")
+
+assert(enable_extensions,
+ "Cannot depend on extensions because enable_extensions=false.")
+
source_set("app_window") {
sources = [
"app_delegate.h",
@@ -29,7 +34,12 @@ source_set("app_window") {
deps = [
"//content/public/common",
- "//extensions:extensions_browser_resources",
- "//extensions/strings",
]
+
+ if (enable_extensions) {
Devlin 2017/06/09 19:11:52 here, too, why this block with the assert?
hugoh_UTC2 2017/06/12 09:19:08 Done. You're right.
+ deps += [
+ "//extensions:extensions_browser_resources",
+ "//extensions/strings",
+ ]
+ }
}

Powered by Google App Engine
This is Rietveld 408576698