Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: extensions/browser/api/BUILD.gn

Issue 2904443004: Allow generation of a chromium outdirs when enable_extensions=false (Closed)
Patch Set: Assert enable_extensions: common/BUILD.gn and features/BUILD.gn are marked TODO(crbug.com/731689) Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/BUILD.gn
diff --git a/extensions/browser/api/BUILD.gn b/extensions/browser/api/BUILD.gn
index b17d2e25f272ccdf7c67aec01f5cfdd7cedc086d..b67409d683b5dd9a9b381812f4aa9e47b3f6ca37 100644
--- a/extensions/browser/api/BUILD.gn
+++ b/extensions/browser/api/BUILD.gn
@@ -2,9 +2,14 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//extensions/features/features.gni")
import("//extensions/common/api/schema.gni")
+import("//extensions/features/features.gni")
import("//tools/json_schema_compiler/json_schema_api.gni")
+assert(enable_extensions,
+ "Cannot depend on extensions because enable_extensions=false.")
+
source_set("api") {
sources = [
"api_resource.cc",
@@ -36,63 +41,73 @@ source_set("api") {
"//base",
"//content/public/browser",
"//content/public/common",
- "//extensions/browser/api/activity_log",
- "//extensions/browser/api/alarms",
- "//extensions/browser/api/app_current_window_internal",
- "//extensions/browser/api/app_runtime",
- "//extensions/browser/api/app_window",
- "//extensions/browser/api/audio",
- "//extensions/browser/api/bluetooth",
- "//extensions/browser/api/bluetooth_low_energy",
- "//extensions/browser/api/bluetooth_socket",
- "//extensions/browser/api/cast_channel",
- "//extensions/browser/api/declarative",
- "//extensions/browser/api/declarative_content",
- "//extensions/browser/api/declarative_webrequest",
- "//extensions/browser/api/display_source",
- "//extensions/browser/api/dns",
- "//extensions/browser/api/document_scan",
- "//extensions/browser/api/file_handlers",
- "//extensions/browser/api/hid",
- "//extensions/browser/api/idle",
- "//extensions/browser/api/management",
- "//extensions/browser/api/messaging",
- "//extensions/browser/api/metrics_private",
- "//extensions/browser/api/mime_handler_private",
- "//extensions/browser/api/networking_private",
- "//extensions/browser/api/power",
- "//extensions/browser/api/printer_provider",
- "//extensions/browser/api/printer_provider_internal",
- "//extensions/browser/api/runtime",
- "//extensions/browser/api/serial",
- "//extensions/browser/api/socket",
- "//extensions/browser/api/sockets_tcp",
- "//extensions/browser/api/sockets_tcp_server",
- "//extensions/browser/api/sockets_udp",
- "//extensions/browser/api/storage",
- "//extensions/browser/api/system_cpu",
- "//extensions/browser/api/system_display",
- "//extensions/browser/api/system_info",
- "//extensions/browser/api/system_memory",
- "//extensions/browser/api/system_network",
- "//extensions/browser/api/system_storage",
- "//extensions/browser/api/test",
- "//extensions/browser/api/usb",
- "//extensions/browser/api/virtual_keyboard_private",
- "//extensions/browser/api/web_request",
- "//extensions/common",
"//ipc",
]
+ if (enable_extensions) {
Devlin 2017/06/09 19:11:52 why do we need this if with the assert above?
hugoh_UTC2 2017/06/12 09:19:08 Done. True. Assert is enough.
+ public_deps += [
+ "//extensions/browser/api/activity_log",
+ "//extensions/browser/api/alarms",
+ "//extensions/browser/api/app_current_window_internal",
+ "//extensions/browser/api/app_runtime",
+ "//extensions/browser/api/app_window",
+ "//extensions/browser/api/audio",
+ "//extensions/browser/api/bluetooth",
+ "//extensions/browser/api/bluetooth_low_energy",
+ "//extensions/browser/api/bluetooth_socket",
+ "//extensions/browser/api/cast_channel",
+ "//extensions/browser/api/declarative",
+ "//extensions/browser/api/declarative_content",
+ "//extensions/browser/api/declarative_webrequest",
+ "//extensions/browser/api/display_source",
+ "//extensions/browser/api/dns",
+ "//extensions/browser/api/document_scan",
+ "//extensions/browser/api/file_handlers",
+ "//extensions/browser/api/hid",
+ "//extensions/browser/api/idle",
+ "//extensions/browser/api/management",
+ "//extensions/browser/api/messaging",
+ "//extensions/browser/api/metrics_private",
+ "//extensions/browser/api/mime_handler_private",
+ "//extensions/browser/api/networking_private",
+ "//extensions/browser/api/power",
+ "//extensions/browser/api/printer_provider",
+ "//extensions/browser/api/printer_provider_internal",
+ "//extensions/browser/api/runtime",
+ "//extensions/browser/api/serial",
+ "//extensions/browser/api/socket",
+ "//extensions/browser/api/sockets_tcp",
+ "//extensions/browser/api/sockets_tcp_server",
+ "//extensions/browser/api/sockets_udp",
+ "//extensions/browser/api/storage",
+ "//extensions/browser/api/system_cpu",
+ "//extensions/browser/api/system_display",
+ "//extensions/browser/api/system_info",
+ "//extensions/browser/api/system_memory",
+ "//extensions/browser/api/system_network",
+ "//extensions/browser/api/system_storage",
+ "//extensions/browser/api/test",
+ "//extensions/browser/api/usb",
+ "//extensions/browser/api/virtual_keyboard_private",
+ "//extensions/browser/api/web_request",
+ "//extensions/common",
+ ]
+ }
+
deps = [
"//base:i18n",
"//components/keyed_service/content:content",
- "//extensions/browser:browser_sources",
- "//extensions/browser/guest_view",
- "//extensions/common/api",
- "//extensions/strings",
]
+ if (enable_extensions) {
+ deps += [
+ "//extensions/browser:browser_sources",
+ "//extensions/browser/guest_view",
+ "//extensions/common/api",
+ "//extensions/strings",
+ ]
+ }
+
# TODO(michaelpg): Move these deps to the individual APIs that require them.
deps += [
"//components/onc",
@@ -141,8 +156,13 @@ json_schema_api("api_registration") {
deps = [
":api",
"//device/serial",
- "//extensions/common/api",
- "//extensions/common/api/cast_channel:cast_channel_proto",
"//skia",
]
+
+ if (enable_extensions) {
+ deps += [
+ "//extensions/common/api",
+ "//extensions/common/api/cast_channel:cast_channel_proto",
+ ]
+ }
}

Powered by Google App Engine
This is Rietveld 408576698