Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2217)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/media/router/BUILD.gn

Issue 2904443004: Allow generation of a chromium outdirs when enable_extensions=false (Closed)
Patch Set: Assert enable_extensions: common/BUILD.gn and features/BUILD.gn are marked TODO(crbug.com/731689) Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/devtools/BUILD.gn ('K') | « chrome/browser/devtools/BUILD.gn ('k') | chrome/browser/ui/BUILD.gn » ('j') | extensions/browser/api/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/router/BUILD.gn
diff --git a/chrome/browser/media/router/BUILD.gn b/chrome/browser/media/router/BUILD.gn
index 14b5095fc38cd2f75afe25553d57e1e35f34f4a1..3daae314046cd787ebb0d2160bc3f8e329ba16f7 100644
--- a/chrome/browser/media/router/BUILD.gn
+++ b/chrome/browser/media/router/BUILD.gn
@@ -3,6 +3,7 @@
# found in the LICENSE file.
#
+import("//extensions/features/features.gni")
import("//testing/test.gni")
static_library("router") {
@@ -63,7 +64,7 @@ static_library("router") {
"route_message_observer.h",
]
- if (!is_android) {
+ if (!is_android && enable_extensions) {
Devlin 2017/06/09 19:11:52 ditto here and line 106 - probably just want an if
hugoh_UTC2 2017/06/12 09:19:08 Done.
deps += [
"discovery",
"//extensions/browser",
@@ -102,7 +103,7 @@ static_library("test_support") {
"test_helper.h",
]
- if (!is_android) {
+ if (!is_android && enable_extensions) {
deps += [
"//chrome/common/media_router/mojo:media_router",
"//chrome/common/media_router/mojo:media_router_test_interfaces",
« chrome/browser/devtools/BUILD.gn ('K') | « chrome/browser/devtools/BUILD.gn ('k') | chrome/browser/ui/BUILD.gn » ('j') | extensions/browser/api/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698