Generate methods for TextEmphasis properties in ComputedStyleBase.

Generate methods for TextEmphasis properties in ComputedStyleBase.

This patch generates getters/setters/mapping for TextEmphasisFill,
TextEmphasisPosition, TextEmphasisCustomMark.

BUG=628043
Review-Url: https://codereview.chromium.org/2904403002
Cr-Commit-Position: refs/heads/master@{#475800}
Committed: https://chromium.googlesource.com/chromium/src/+/13eccd8f81e732469a8db4cd1540a80825c709b3

[shend, 2017-05-29 03:09:10]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 03:09:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 03:11:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 03:11:12]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[shend, 2017-05-29 03:27:27]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 03:27:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 05:53:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 05:53:19]

Dry run: This issue passed the CQ dry run.

[shend, 2017-05-29 23:45:21]

shend@chromium.org changed reviewers:
+ meade@chromium.org

[shend, 2017-05-29 23:45:22]

Hi Eddy, PTAL

[meade_UTC10, 2017-05-30 03:51:34]

lgtm

I think you forgot to attach a diff?

https://codereview.chromium.org/2904403002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 (right):

https://codereview.chromium.org/2904403002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5:420: //
TODO(shend): Put this in text-emphasis-style in CSSProperties.json5.
What's blocking doing it now? Just keeping the CL small or something else?

[shend, 2017-05-30 06:30:32]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 06:30:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 06:32:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 06:32:33]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[shend, 2017-05-30 22:25:56]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 22:26:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 02:10:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 02:10:04]

Dry run: This issue passed the CQ dry run.

[shend, 2017-05-31 04:23:01]

On 2017/05/30 at 03:51:34, meade wrote:
> lgtm
> 
> I think you forgot to attach a diff?
> 
>
https://codereview.chromium.org/2904403002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5
(right):
> 
>
https://codereview.chromium.org/2904403002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5:420: //
TODO(shend): Put this in text-emphasis-style in CSSProperties.json5.
> What's blocking doing it now? Just keeping the CL small or something else?

That was a mistake. I thought text-emphasis-style was text-emphasis-fill, but
apparently it's different.

[shend, 2017-05-31 04:23:07]

The CQ bit was checked by shend@chromium.org

[shend, 2017-05-31 04:23:07]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2904403002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-31 04:23:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 04:27:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496204587245110,
"parent_rev": "ec0c017a410d4c51bfdc3a0d3423d2cff3c6f064", "commit_rev":
"13eccd8f81e732469a8db4cd1540a80825c709b3"}

[commit-bot: I haz the power, 2017-05-31 04:27:56]

Description was changed from

==========
Generate methods for TextEmphasis properties in ComputedStyleBase.

This patch generates getters/setters/mapping for TextEmphasisFill,
TextEmphasisPosition, TextEmphasisCustomMark.

BUG=628043
==========

to

==========
Generate methods for TextEmphasis properties in ComputedStyleBase.

This patch generates getters/setters/mapping for TextEmphasisFill,
TextEmphasisPosition, TextEmphasisCustomMark.

BUG=628043

Review-Url: https://codereview.chromium.org/2904403002
Cr-Commit-Position: refs/heads/master@{#475800}
Committed:
https://chromium.googlesource.com/chromium/src/+/13eccd8f81e732469a8db4cd1540...
==========

[commit-bot: I haz the power, 2017-05-31 04:27:57]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/13eccd8f81e732469a8db4cd1540...