Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5

Issue 2904403002: Generate methods for TextEmphasis properties in ComputedStyleBase. (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 { 1 {
2 // This file specifies fields in ComputedStyle that we would like to 2 // This file specifies fields in ComputedStyle that we would like to
3 // generate, but are not CSS properties. 3 // generate, but are not CSS properties.
4 4
5 parameters: { 5 parameters: {
6 // If the field has_custom_compare_and_copy, then it does not appear in 6 // If the field has_custom_compare_and_copy, then it does not appear in
7 // ComputedStyle::operator== and ComputedStyle::CopyNonInheritedFromCached. 7 // ComputedStyle::operator== and ComputedStyle::CopyNonInheritedFromCached.
8 has_custom_compare_and_copy: { 8 has_custom_compare_and_copy: {
9 default: false, 9 default: false,
10 }, 10 },
(...skipping 399 matching lines...) Expand 10 before | Expand all | Expand 10 after
410 }, 410 },
411 { 411 {
412 name: "VisitedLinkCaretColorIsAuto", 412 name: "VisitedLinkCaretColorIsAuto",
413 inherited: true, 413 inherited: true,
414 field_template: "storage_only", 414 field_template: "storage_only",
415 type_name: "bool", 415 type_name: "bool",
416 default_value: "true", 416 default_value: "true",
417 field_size: 1, 417 field_size: 1,
418 field_group: "rare-inherited", 418 field_group: "rare-inherited",
419 }, 419 },
420 // TODO(shend): Put this in text-emphasis-style in CSSProperties.json5.
meade_UTC10 2017/05/30 03:51:33 What's blocking doing it now? Just keeping the CL
420 { 421 {
421 name: "TextEmphasisFill", 422 name: "TextEmphasisFill",
422 inherited: true, 423 inherited: true,
423 field_template: "storage_only", 424 field_template: "keyword",
424 type_name: "TextEmphasisFill", 425 type_name: "TextEmphasisFill",
425 default_value: "TextEmphasisFill::kFilled", 426 default_value: "filled",
426 field_size: 1, 427 keywords: ["filled", "open"],
427 field_group: "rare-inherited", 428 field_group: "rare-inherited",
428 }, 429 },
429 { 430 {
430 name: "TextEmphasisMark", 431 name: "TextEmphasisMark",
431 inherited: true, 432 inherited: true,
432 field_template: "storage_only", 433 field_template: "storage_only",
433 type_name: "TextEmphasisMark", 434 type_name: "TextEmphasisMark",
434 default_value: "TextEmphasisMark::kNone", 435 default_value: "TextEmphasisMark::kNone",
435 field_size: 3, 436 field_size: 3,
436 field_group: "rare-inherited", 437 field_group: "rare-inherited",
437 }, 438 },
438 { 439 {
439 name: "TextEmphasisPosition",
440 inherited: true,
441 field_template: "storage_only",
442 type_name: "TextEmphasisPosition",
443 default_value: "TextEmphasisPosition::kOver",
444 field_size: 1,
445 field_group: "rare-inherited",
446 },
447 {
448 name: "TextIndentLine", 440 name: "TextIndentLine",
449 inherited: true, 441 inherited: true,
450 field_template: "storage_only", 442 field_template: "storage_only",
451 type_name: "TextIndentLine", 443 type_name: "TextIndentLine",
452 default_value: "TextIndentLine::kFirstLine", 444 default_value: "TextIndentLine::kFirstLine",
453 field_size: 1, 445 field_size: 1,
454 field_group: "rare-inherited", 446 field_group: "rare-inherited",
455 }, 447 },
456 { 448 {
457 name: "TextIndentType", 449 name: "TextIndentType",
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
522 name: "HyphenationLimitLines", 514 name: "HyphenationLimitLines",
523 inherited: true, 515 inherited: true,
524 field_template: "storage_only", 516 field_template: "storage_only",
525 type_name: "short", 517 type_name: "short",
526 default_value: "-1", 518 default_value: "-1",
527 field_group: "rare-inherited", 519 field_group: "rare-inherited",
528 }, 520 },
529 { 521 {
530 name: "TextEmphasisCustomMark", 522 name: "TextEmphasisCustomMark",
531 inherited: true, 523 inherited: true,
532 field_template: "storage_only", 524 field_template: "external",
533 type_name: "AtomicString", 525 type_name: "AtomicString",
534 include_paths: ["platform/wtf/text/AtomicString.h"], 526 include_paths: ["platform/wtf/text/AtomicString.h"],
535 default_value: "AtomicString()", 527 default_value: "AtomicString()",
536 field_group: "rare-inherited", 528 field_group: "rare-inherited",
537 }, 529 },
538 { 530 {
539 name: "AppliedTextDecorations", 531 name: "AppliedTextDecorations",
540 inherited: true, 532 inherited: true,
541 field_template: "storage_only", 533 field_template: "storage_only",
542 type_name: "AppliedTextDecorationList", 534 type_name: "AppliedTextDecorationList",
543 include_paths: ["core/style/AppliedTextDecorationList.h"], 535 include_paths: ["core/style/AppliedTextDecorationList.h"],
544 default_value: "nullptr", 536 default_value: "nullptr",
545 wrapper_pointer_name: "RefPtr", 537 wrapper_pointer_name: "RefPtr",
546 field_group: "rare-inherited", 538 field_group: "rare-inherited",
547 }, 539 },
548 { 540 {
549 name: "Variables", 541 name: "Variables",
550 inherited: true, 542 inherited: true,
551 field_template: "storage_only", 543 field_template: "storage_only",
552 type_name: "StyleInheritedVariables", 544 type_name: "StyleInheritedVariables",
553 include_paths: ["core/style/StyleInheritedVariables.h"], 545 include_paths: ["core/style/StyleInheritedVariables.h"],
554 default_value: "nullptr", 546 default_value: "nullptr",
555 wrapper_pointer_name: "RefPtr", 547 wrapper_pointer_name: "RefPtr",
556 field_group: "rare-inherited", 548 field_group: "rare-inherited",
557 }, 549 },
558 ], 550 ],
559 } 551 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/CSSProperties.json5 ('k') | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698