Make TextIndentLine an enum class.

Make TextIndentLine an enum class.

This patch makes TextIndentLine an enum class for type safety. The only
change to callers is where TextIndentLine::kEachLine was being used
as a synonym for 'true'. This has been removed with no changes in
behaviour.

BUG=684966
Review-Url: https://codereview.chromium.org/2904383002
Cr-Commit-Position: refs/heads/master@{#475438}
Committed: https://chromium.googlesource.com/chromium/src/+/1b5744eb7bae3f1d327084a487cb96f858ba4b1e

[shend, 2017-05-29 00:38:19]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 00:38:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-05-29 01:48:43]

shend@chromium.org changed reviewers:
+ nainar@chromium.org

[shend, 2017-05-29 01:48:44]

Hi Naina, PTAL

[nainar, 2017-05-29 01:52:50]

lgtm. 

Also maybe run this by eae@ or someone on the layout just to make sure to sanity
check our theory

[commit-bot: I haz the power, 2017-05-29 02:38:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 02:38:13]

Dry run: This issue passed the CQ dry run.

[shend, 2017-05-29 22:49:35]

shend@chromium.org changed reviewers:
+ eae@chromium.org

[shend, 2017-05-29 22:49:35]

eae, PTAL. Thanks!

[eae, 2017-05-30 03:57:22]

LGTM

https://codereview.chromium.org/2904383002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
(right):

https://codereview.chromium.org/2904383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h:1565:
style.GetTextIndentLine() != TextIndentLine::kFirstLine))
Thanks for reversing the check here, makes it much easier to read.

[shend, 2017-05-30 04:01:28]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-05-30 04:01:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 06:12:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496116888223140, "parent_rev":
"67dc05043dfa234b336708114248949e601be0e3", "commit_rev":
"1b5744eb7bae3f1d327084a487cb96f858ba4b1e"}

[commit-bot: I haz the power, 2017-05-30 06:12:44]

Description was changed from

==========
Make TextIndentLine an enum class.

This patch makes TextIndentLine an enum class for type safety. The only
change to callers is where TextIndentLine::kEachLine was being used
as a synonym for 'true'. This has been removed with no changes in
behaviour.

BUG=684966
==========

to

==========
Make TextIndentLine an enum class.

This patch makes TextIndentLine an enum class for type safety. The only
change to callers is where TextIndentLine::kEachLine was being used
as a synonym for 'true'. This has been removed with no changes in
behaviour.

BUG=684966

Review-Url: https://codereview.chromium.org/2904383002
Cr-Commit-Position: refs/heads/master@{#475438}
Committed:
https://chromium.googlesource.com/chromium/src/+/1b5744eb7bae3f1d327084a487cb...
==========

[commit-bot: I haz the power, 2017-05-30 06:12:49]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1b5744eb7bae3f1d327084a487cb...