third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h - Issue 2904383002: Make TextIndentLine an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

Issue 2904383002: Make TextIndentLine an enum class. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

diff --git a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

index 3a59fbf7deb7af97de3d6d9b578a98717d7e5371..01e36ed93eb3bd550ef8038ec501ed7757a35688 100644

--- a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

+++ b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

@@ -1560,8 +1560,9 @@ inline IndentTextOrNot RequiresIndent(bool is_first_line,

bool is_after_hard_line_break,

const ComputedStyle& style) {

IndentTextOrNot indent_text = kDoNotIndentText;

- if (is_first_line || (is_after_hard_line_break &&

- style.GetTextIndentLine()) == TextIndentLine::kEachLine)

+ if (is_first_line ||

+ (is_after_hard_line_break &&

+ style.GetTextIndentLine() != TextIndentLine::kFirstLine))

eae 2017/05/30 03:57:22 Thanks for reversing the check here, makes it much

indent_text = kIndentText;

if (style.GetTextIndentType() == TextIndentType::kHanging)

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyleConstants.h » ('j') | no next file with comments »