Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 2904333002: Reorder methods in BookmarkBubbleView. (Closed)

Created:
3 years, 7 months ago by tapted
Modified:
3 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reorder methods in BookmarkBubbleView. BUG=726187 Review-Url: https://codereview.chromium.org/2904333002 Cr-Commit-Position: refs/heads/master@{#475216} Committed: https://chromium.googlesource.com/chromium/src/+/23c963cd61e359cc18548e1c2ed6116fdfbe4fdc

Patch Set 1 #

Patch Set 2 : selfnit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -104 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h View 4 chunks +18 lines, -23 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc View 1 6 chunks +96 lines, -81 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (12 generated)
tapted
3 years, 7 months ago (2017-05-27 00:18:55 UTC) #8
Peter Kasting
LGTM
3 years, 7 months ago (2017-05-27 00:19:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904333002/40001
3 years, 7 months ago (2017-05-27 01:12:26 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-27 01:56:06 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/23c963cd61e359cc18548e1c2ed6...

Powered by Google App Engine
This is Rietveld 408576698