Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2371)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h

Issue 2904333002: Reorder methods in BookmarkBubbleView. (Closed)
Patch Set: selfnit Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
index f9d510e85f2eeee6491a4a2e5850f1b0a0a00195..24b62814d6a06c0ec4a22043fe33e5ac16c1c25d 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
@@ -67,16 +67,29 @@ class BookmarkBubbleView : public LocationBarBubbleDelegateView,
~BookmarkBubbleView() override;
- // views::WidgetDelegate:
- void WindowClosing() override;
- bool AcceleratorPressed(const ui::Accelerator& accelerator) override;
+ // views::LocationBarBubbleDelegateView:
+ View* GetInitiallyFocusedView() override;
+ base::string16 GetWindowTitle() const override;
gfx::ImageSkia GetWindowIcon() override;
bool ShouldShowWindowIcon() const override;
+ void WindowClosing() override;
+ View* CreateFootnoteView() override;
+ const char* GetClassName() const override;
+ bool AcceleratorPressed(const ui::Accelerator& accelerator) override;
+ void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
+
+ // views::ButtonListener:
+ void ButtonPressed(views::Button* sender, const ui::Event& event) override;
+
+ // views::ComboboxListener:
+ void OnPerformAction(views::Combobox* combobox) override;
+
+ // DesktopIOSPromotionFootnoteDelegate:
+ void OnIOSPromotionFootnoteLinkClicked() override;
protected:
- // views::BubbleDialogDelegateView method.
+ // views::LocationBarBubbleDelegateView:
void Init() override;
- base::string16 GetWindowTitle() const override;
private:
friend class BookmarkBubbleViewTest;
@@ -84,11 +97,6 @@ class BookmarkBubbleView : public LocationBarBubbleDelegateView,
FRIEND_TEST_ALL_PREFIXES(BookmarkBubbleViewTest, SyncPromoSignedIn);
FRIEND_TEST_ALL_PREFIXES(BookmarkBubbleViewTest, SyncPromoNotSignedIn);
- // views::BubbleDialogDelegateView:
- const char* GetClassName() const override;
- View* GetInitiallyFocusedView() override;
- View* CreateFootnoteView() override;
-
// Creates a BookmarkBubbleView.
BookmarkBubbleView(views::View* anchor_view,
bookmarks::BookmarkBubbleObserver* observer,
@@ -100,16 +108,6 @@ class BookmarkBubbleView : public LocationBarBubbleDelegateView,
// Returns the title to display.
base::string16 GetTitle();
- // Overridden from views::View:
- void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
-
- // Overridden from views::ButtonListener:
- // Closes the bubble or opens the edit dialog.
- void ButtonPressed(views::Button* sender, const ui::Event& event) override;
-
- // Overridden from views::ComboboxListener:
- void OnPerformAction(views::Combobox* combobox) override;
-
// Handle the message when the user presses a button.
void HandleButtonPressed(views::Button* sender);
@@ -119,9 +117,6 @@ class BookmarkBubbleView : public LocationBarBubbleDelegateView,
// Sets the title and parent of the node.
void ApplyEdits();
- // DesktopIOSPromotionFootnoteDelegate :
- void OnIOSPromotionFootnoteLinkClicked() override;
-
#if defined(OS_WIN)
// Check eligiblity to showthe iOS promotion from a specific entry point.
bool IsIOSPromotionEligible(
« no previous file with comments | « no previous file | chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698