Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2904113002: Replacing WM_TOUCH with WM_POINTER for touch events on Wins 8+ (Closed)

Created:
3 years, 6 months ago by lanwei
Modified:
3 years, 5 months ago
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replacing WM_TOUCH with WM_POINTER for touch events on Wins 8+ Since we already used WM_POINTER for stylus input, and WM_POINTER provides better API on touch events, we should use WM_POINTER on touch events as well, replacing the current WM_TOUCH messages for Windows 8(+). BUG=726766 Review-Url: https://codereview.chromium.org/2904113002 Cr-Commit-Position: refs/heads/master@{#482977} Committed: https://chromium.googlesource.com/chromium/src/+/4c69348ec2a2721e25ae02b9bc75aff88e38973c

Patch Set 1 : wm touch #

Total comments: 8

Patch Set 2 : wm touch #

Total comments: 2

Patch Set 3 : wm touch #

Patch Set 4 : Add a browser test #

Total comments: 32

Patch Set 5 : wm touch #

Patch Set 6 : wm touch #

Total comments: 12

Patch Set 7 : wm touch #

Total comments: 16

Patch Set 8 : wm touch #

Total comments: 17

Patch Set 9 : wm touch #

Total comments: 1

Patch Set 10 : wm touch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+405 lines, -88 lines) Patch
A chrome/browser/ui/views/touch_events_interactive_uitest_win.cc View 1 2 3 4 5 6 7 8 9 1 chunk +114 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/test/ui_controls_factory_aurawin.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/test/ui_controls.h View 1 2 3 4 5 6 7 8 2 chunks +12 lines, -0 lines 0 comments Download
M ui/base/test/ui_controls_aura.h View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -0 lines 0 comments Download
M ui/base/test/ui_controls_aura.cc View 1 2 3 4 5 6 7 8 1 chunk +8 lines, -0 lines 0 comments Download
M ui/base/test/ui_controls_internal_win.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/test/ui_controls_internal_win.cc View 1 2 3 4 5 6 7 1 chunk +76 lines, -0 lines 0 comments Download
M ui/base/test/ui_controls_win.cc View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M ui/events/event.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/win/hwnd_message_handler.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 1 2 3 4 5 6 3 chunks +171 lines, -88 lines 0 comments Download

Messages

Total messages: 133 (109 generated)
lanwei
3 years, 6 months ago (2017-05-26 17:39:40 UTC) #12
dtapuska
https://codereview.chromium.org/2904113002/diff/20001/ui/views/win/hwnd_message_handler.cc File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/2904113002/diff/20001/ui/views/win/hwnd_message_handler.cc#newcode1690 ui/views/win/hwnd_message_handler.cc:1690: if (pointer_type == PT_PEN) { Can't this be a ...
3 years, 6 months ago (2017-05-26 17:56:45 UTC) #13
dtapuska
https://codereview.chromium.org/2904113002/diff/20001/ui/views/win/hwnd_message_handler.cc File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/2904113002/diff/20001/ui/views/win/hwnd_message_handler.cc#newcode2670 ui/views/win/hwnd_message_handler.cc:2670: int rotation_angle = pointer_touch_info.orientation; On 2017/05/26 17:56:45, dtapuska wrote: ...
3 years, 6 months ago (2017-05-26 18:08:21 UTC) #14
lanwei
https://codereview.chromium.org/2904113002/diff/20001/ui/views/win/hwnd_message_handler.cc File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/2904113002/diff/20001/ui/views/win/hwnd_message_handler.cc#newcode2670 ui/views/win/hwnd_message_handler.cc:2670: int rotation_angle = pointer_touch_info.orientation; On 2017/05/26 18:08:21, dtapuska wrote: ...
3 years, 6 months ago (2017-05-26 19:24:56 UTC) #16
mustaq
https://codereview.chromium.org/2904113002/diff/20001/ui/views/win/hwnd_message_handler.cc File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/2904113002/diff/20001/ui/views/win/hwnd_message_handler.cc#newcode2670 ui/views/win/hwnd_message_handler.cc:2670: int rotation_angle = pointer_touch_info.orientation; On 2017/05/26 19:24:56, lanwei wrote: ...
3 years, 6 months ago (2017-05-26 19:59:15 UTC) #17
lanwei
https://codereview.chromium.org/2904113002/diff/20001/ui/views/win/hwnd_message_handler.cc File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/2904113002/diff/20001/ui/views/win/hwnd_message_handler.cc#newcode1690 ui/views/win/hwnd_message_handler.cc:1690: if (pointer_type == PT_PEN) { On 2017/05/26 17:56:45, dtapuska ...
3 years, 6 months ago (2017-05-29 18:29:43 UTC) #23
dtapuska
On 2017/05/29 18:29:43, lanwei wrote: > https://codereview.chromium.org/2904113002/diff/20001/ui/views/win/hwnd_message_handler.cc > File ui/views/win/hwnd_message_handler.cc (right): > > https://codereview.chromium.org/2904113002/diff/20001/ui/views/win/hwnd_message_handler.cc#newcode1690 > ...
3 years, 6 months ago (2017-05-29 18:47:25 UTC) #24
Navid Zolghadr
lgtm https://codereview.chromium.org/2904113002/diff/40001/ui/views/win/hwnd_message_handler.cc File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/2904113002/diff/40001/ui/views/win/hwnd_message_handler.cc#newcode1684 ui/views/win/hwnd_message_handler.cc:1684: // touch and mouse inputs. nit: Do we ...
3 years, 6 months ago (2017-05-29 19:08:22 UTC) #25
mustaq
lgtm https://codereview.chromium.org/2904113002/diff/40001/ui/events/event.h File ui/events/event.h (right): https://codereview.chromium.org/2904113002/diff/40001/ui/events/event.h#newcode720 ui/events/event.h:720: // TODO(726824): Remove rotation_angle_ from ui::TouchEvent, just use ...
3 years, 6 months ago (2017-05-29 19:15:05 UTC) #26
sky
How about some test coverage? We have tests that run on win10. Is it possible ...
3 years, 6 months ago (2017-05-30 16:40:24 UTC) #27
dtapuska
On 2017/05/30 16:40:24, sky wrote: > How about some test coverage? We have tests that ...
3 years, 6 months ago (2017-05-30 16:49:11 UTC) #28
lanwei
3 years, 6 months ago (2017-06-07 17:41:56 UTC) #47
sky
https://codereview.chromium.org/2904113002/diff/160001/chrome/browser/touchevents_browsertest.cc File chrome/browser/touchevents_browsertest.cc (right): https://codereview.chromium.org/2904113002/diff/160001/chrome/browser/touchevents_browsertest.cc#newcode52 chrome/browser/touchevents_browsertest.cc:52: DISALLOW_COPY_AND_ASSIGN(TouchEventsTest); private: https://codereview.chromium.org/2904113002/diff/160001/chrome/browser/touchevents_browsertest.cc#newcode55 chrome/browser/touchevents_browsertest.cc:55: #if defined(OS_WIN) Make it so ...
3 years, 6 months ago (2017-06-07 19:42:46 UTC) #50
ananta
https://codereview.chromium.org/2904113002/diff/160001/ui/base/test/ui_controls_internal_win.cc File ui/base/test/ui_controls_internal_win.cc (right): https://codereview.chromium.org/2904113002/diff/160001/ui/base/test/ui_controls_internal_win.cc#newcode367 ui/base/test/ui_controls_internal_win.cc:367: InjectTouchInput(num, contact_); // Injecting the touch down on screen ...
3 years, 6 months ago (2017-06-09 03:13:12 UTC) #51
lanwei
sky@ could you please take a look at the tests? https://codereview.chromium.org/2904113002/diff/160001/chrome/browser/touchevents_browsertest.cc File chrome/browser/touchevents_browsertest.cc (right): https://codereview.chromium.org/2904113002/diff/160001/chrome/browser/touchevents_browsertest.cc#newcode52 ...
3 years, 6 months ago (2017-06-22 18:38:45 UTC) #96
sky
https://codereview.chromium.org/2904113002/diff/160001/chrome/browser/touchevents_browsertest.cc File chrome/browser/touchevents_browsertest.cc (right): https://codereview.chromium.org/2904113002/diff/160001/chrome/browser/touchevents_browsertest.cc#newcode55 chrome/browser/touchevents_browsertest.cc:55: #if defined(OS_WIN) On 2017/06/22 18:38:45, lanwei wrote: > On ...
3 years, 6 months ago (2017-06-22 20:54:22 UTC) #99
lanwei
https://codereview.chromium.org/2904113002/diff/160001/ui/base/test/ui_controls_internal_win.cc File ui/base/test/ui_controls_internal_win.cc (right): https://codereview.chromium.org/2904113002/diff/160001/ui/base/test/ui_controls_internal_win.cc#newcode368 ui/base/test/ui_controls_internal_win.cc:368: Sleep(20); On 2017/06/22 20:54:21, sky wrote: > On 2017/06/22 ...
3 years, 5 months ago (2017-06-23 20:06:05 UTC) #105
sky
Thanks for your patience. I think you are close. https://codereview.chromium.org/2904113002/diff/420001/ui/base/test/ui_controls.h File ui/base/test/ui_controls.h (right): https://codereview.chromium.org/2904113002/diff/420001/ui/base/test/ui_controls.h#newcode102 ui/base/test/ui_controls.h:102: ...
3 years, 5 months ago (2017-06-24 00:01:15 UTC) #108
lanwei
https://codereview.chromium.org/2904113002/diff/420001/ui/base/test/ui_controls.h File ui/base/test/ui_controls.h (right): https://codereview.chromium.org/2904113002/diff/420001/ui/base/test/ui_controls.h#newcode102 ui/base/test/ui_controls.h:102: const base::Closure& task); On 2017/06/24 00:01:14, sky wrote: > ...
3 years, 5 months ago (2017-06-26 22:59:29 UTC) #116
sky
https://codereview.chromium.org/2904113002/diff/520001/chrome/browser/ui/views/touch_events_interactive_uitest_win.cc File chrome/browser/ui/views/touch_events_interactive_uitest_win.cc (right): https://codereview.chromium.org/2904113002/diff/520001/chrome/browser/ui/views/touch_events_interactive_uitest_win.cc#newcode62 chrome/browser/ui/views/touch_events_interactive_uitest_win.cc:62: TouchEventsViewTest() : ViewEventTestBase(), touch_view_(NULL) {} NULL -> nullptr https://codereview.chromium.org/2904113002/diff/520001/chrome/browser/ui/views/touch_events_interactive_uitest_win.cc#newcode71 ...
3 years, 5 months ago (2017-06-27 02:19:48 UTC) #117
lanwei
https://codereview.chromium.org/2904113002/diff/520001/chrome/browser/ui/views/touch_events_interactive_uitest_win.cc File chrome/browser/ui/views/touch_events_interactive_uitest_win.cc (right): https://codereview.chromium.org/2904113002/diff/520001/chrome/browser/ui/views/touch_events_interactive_uitest_win.cc#newcode62 chrome/browser/ui/views/touch_events_interactive_uitest_win.cc:62: TouchEventsViewTest() : ViewEventTestBase(), touch_view_(NULL) {} On 2017/06/27 02:19:47, sky ...
3 years, 5 months ago (2017-06-27 18:55:42 UTC) #120
sky
LGTM https://codereview.chromium.org/2904113002/diff/520001/ui/views/win/hwnd_message_handler.cc File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/2904113002/diff/520001/ui/views/win/hwnd_message_handler.cc#newcode2662 ui/views/win/hwnd_message_handler.cc:2662: gfx::Point touch_point = gfx::Point(client_point.x, client_point.y); On 2017/06/27 18:55:42, ...
3 years, 5 months ago (2017-06-27 22:36:43 UTC) #123
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904113002/560001
3 years, 5 months ago (2017-06-28 14:14:49 UTC) #130
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 14:19:19 UTC) #133
Message was sent while issue was closed.
Committed patchset #10 (id:560001) as
https://chromium.googlesource.com/chromium/src/+/4c69348ec2a2721e25ae02b9bc75...

Powered by Google App Engine
This is Rietveld 408576698