Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 2904033002: Use hasSelection() instead of mHasSelection (Closed)

Created:
3 years, 7 months ago by amaralp
Modified:
3 years, 7 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use hasSelection() instead of mHasSelection We should be using the getter method, hasSelection() instead of accessing the mHasSelection directly. This will make things simpler in crrev.com/2785853002 when hasSelection() will do something more complicated than returning a boolean field. BUG=627234 Review-Url: https://codereview.chromium.org/2904033002 Cr-Commit-Position: refs/heads/master@{#474739} Committed: https://chromium.googlesource.com/chromium/src/+/2d123058c5e6ba14b52241c6d39fbbbeebece1bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
amaralp1
PTAL
3 years, 7 months ago (2017-05-25 07:15:18 UTC) #4
aelias_OOO_until_Jul13
lgtm
3 years, 7 months ago (2017-05-25 18:56:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904033002/1
3 years, 7 months ago (2017-05-25 18:59:29 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 19:04:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2d123058c5e6ba14b52241c6d39f...

Powered by Google App Engine
This is Rietveld 408576698