Use hasSelection() instead of mHasSelection

content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser;
 
 import android.annotation.TargetApi;
 import android.app.Activity;
 import android.app.SearchManager;
 import android.content.ClipData;
@@ skipping 215 matching lines @@
     /**
      * Show (activate) android action mode by starting it.
      *
      * <p>Action mode in floating mode is tried first, and then falls back to
      * a normal one.
      * <p> If the action mode cannot be created the selection is cleared.
      */
     public void showActionModeOrClearOnFailure() {
         mPendingShowActionMode = false;
 
-        if (!isActionModeSupported() || !mHasSelection) return;
+        if (!isActionModeSupported() || !hasSelection()) return;
 
         // Just refresh the view if action mode already exists.
         if (isActionModeValid()) {
             // Try/catch necessary for framework bug, crbug.com/446717.
             try {
                 mActionMode.invalidate();
             } catch (NullPointerException e) {
                 Log.w(TAG, "Ignoring NPE from ActionMode.invalidate() as workaround for L", e);
             }
             hideActionMode(false);
@@ skipping 655 matching lines @@
             return isAllowedByClient && isShareAvailable();
         }
         return isAllowedByClient;
     }
 
     @Override
     public void onReceivedProcessTextResult(int resultCode, Intent data) {
         if (mWebContents == null || resultCode != Activity.RESULT_OK || data == null) return;
 
         // Do not handle the result if no text is selected or current selection is not editable.
-        if (!mHasSelection || !isSelectionEditable()) return;
+        if (!hasSelection() || !isSelectionEditable()) return;
 
         CharSequence result = data.getCharSequenceExtra(Intent.EXTRA_PROCESS_TEXT);
         if (result != null) {
             // TODO(hush): Use a variant of replace that re-selects the replaced text.
             // crbug.com/546710
             mWebContents.replace(result.toString());
         }
     }
 
     void restoreSelectionPopupsIfNecessary() {
-        if (mHasSelection && !isActionModeValid()) {
+        if (hasSelection() && !isActionModeValid()) {
             showActionModeOrClearOnFailure();
         }
     }
 
     // All coordinates are in DIP.
     @CalledByNative
     private void onSelectionEvent(int eventType, int left, int top, int right, int bottom) {
         // Ensure the provided selection coordinates form a non-empty rect, as required by
         // the selection action mode.
         if (left == right) ++right;
@@ skipping 159 matching lines @@
     /**
      * @return Whether the page has an active, touch-controlled selection region.
      */
     @VisibleForTesting
     public boolean hasSelection() {
         return mHasSelection;
     }
 
     @Override
     public String getSelectedText() {
-        return mHasSelection ? mLastSelectedText : "";
+        return hasSelection() ? mLastSelectedText : "";
     }
 
     private boolean isShareAvailable() {
         Intent intent = new Intent(Intent.ACTION_SEND);
         intent.setType("text/plain");
         return mContext.getPackageManager().queryIntentActivities(intent,
                 PackageManager.MATCH_DEFAULT_ONLY).size() > 0;
     }
 
     // TODO(timav): Use |TextClassifier| instead of |Object| after we switch to Android SDK 26.
@@ skipping 20 matching lines @@
      */
     public Object getCustomTextClassifier() {
         return mSelectionClient == null ? null : mSelectionClient.getCustomTextClassifier();
     }
 
     // The callback class that delivers result from a SmartSelectionClient.
     private class SmartSelectionCallback implements SmartSelectionProvider.ResultCallback {
         @Override
         public void onClassified(SmartSelectionProvider.Result result) {
             // If the selection does not exist any more, discard |result|.
-            if (!mHasSelection) {
+            if (!hasSelection()) {
                 assert !mHidden;
                 assert mClassificationResult == null;
                 mPendingShowActionMode = false;
                 return;
             }
 
             // Do not allow classifier to shorten the selection. If the suggested selection is
             // smaller than the original we throw away classification result and show the menu.
             // TODO(amaralp): This was added to fix the SelectAll problem in
             // http://crbug.com/714106. Once we know the cause of the original selection we can
@@ skipping 25 matching lines @@
                 if (mPendingShowActionMode) return;
             }
 
             // Rely on this method to clear |mHidden| and unhide the action mode.
             showActionModeOrClearOnFailure();
         }
     };
 
     private native void nativeInit(WebContents webContents);
 }