Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2903733002: [SmartText selection] Restore separator between assist and other items (Closed)

Created:
3 years, 7 months ago by Tima Vaisburd
Modified:
3 years, 7 months ago
Reviewers:
Ted C, amaralp, boliu
CC:
agrieve+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smarttext selection] Restore separator between assist and other items The spec recommends having a separator between an assist item (map, phone, etc.) and others. The separator is a menu group separator, we enable it by having a separate menu group for the assist item. BUG=725693 Review-Url: https://codereview.chromium.org/2903733002 Cr-Commit-Position: refs/heads/master@{#474355} Committed: https://chromium.googlesource.com/chromium/src/+/78e10e9f196add35245bba8e7b74b1baa7085072

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M content/public/android/java/res/menu/select_action_menu.xml View 1 chunk +6 lines, -4 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 21 (12 generated)
Tima Vaisburd
PTAL.
3 years, 7 months ago (2017-05-23 22:55:53 UTC) #5
boliu
lgtm
3 years, 7 months ago (2017-05-23 22:57:57 UTC) #6
amaralp
lgtm
3 years, 7 months ago (2017-05-23 23:04:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903733002/1
3 years, 7 months ago (2017-05-24 00:21:25 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/445649)
3 years, 7 months ago (2017-05-24 00:32:01 UTC) #13
Tima Vaisburd
I missed the fact that res/ has separate owners. Ted, may I ask for an ...
3 years, 7 months ago (2017-05-24 00:40:16 UTC) #15
Ted C
lgtm
3 years, 7 months ago (2017-05-24 17:47:17 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903733002/1
3 years, 7 months ago (2017-05-24 18:00:33 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 18:08:04 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/78e10e9f196add35245bba8e7b74...

Powered by Google App Engine
This is Rietveld 408576698