Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

Issue 2903733002: [SmartText selection] Restore separator between assist and other items (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/android/java/res/menu/select_action_menu.xml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java b/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
index 25bf79f4ef21b09d816c14b95109d26bd39ee8cb..23bd15a8aea305ae7cfd523b9e917372fc3f4445 100644
--- a/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
+++ b/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
@@ -448,6 +448,7 @@ public class SelectionPopupController extends ActionModeCallbackHelper {
@Override
public boolean onPrepareActionMode(ActionMode mode, Menu menu) {
menu.removeGroup(R.id.select_action_menu_default_items);
+ menu.removeGroup(R.id.select_action_menu_assist_items);
menu.removeGroup(R.id.select_action_menu_text_processing_menus);
createActionMenu(mode, menu);
return true;
@@ -585,7 +586,7 @@ public class SelectionPopupController extends ActionModeCallbackHelper {
// Android O SDK and remove |mAssistMenuItemId|.
if (mClassificationResult != null && mClassificationResult.hasNamedAction()) {
- descriptor.addItem(R.id.select_action_menu_default_items, mAssistMenuItemId, 1,
+ descriptor.addItem(R.id.select_action_menu_assist_items, mAssistMenuItemId, 1,
mClassificationResult.label, mClassificationResult.icon);
}
}
« no previous file with comments | « content/public/android/java/res/menu/select_action_menu.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698