Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2903533002: Revert of [es2015] Precompute the descriptive string for symbols. (Closed)

Created:
3 years, 7 months ago by Michael Achenbach
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, Hannes Payer (out of office), v8-ppc-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es2015] Precompute the descriptive string for symbols. (patchset #3 id:40001 of https://codereview.chromium.org/2900703002/ ) Reason for revert: Speculative revert for: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/8901 Original issue's description: > [es2015] Precompute the descriptive string for symbols. > > Previously the String constructor and the Symbol.prototype.toString > methods had to compute the descriptive string for a Symbol on the fly, > which can produce a lot of garbage when this happens a lot, i.e. when > the String representation of a Symbol is used often. Now instead of > doing this on-demand we can just do it upfront when creating the Symbol. > > That way we also ensure that we won't throw an exception when accessing > the descriptive string of a Symbol, due to potential String length > overflow, but have the exception during Symbol creation upfront, which > is a lot less surprising behavior. > > BUG=v8:6278, v8:6344, v8:6350 > TBR=mlippautz@chromium.org > R=ishell@chromium.org > > Review-Url: https://codereview.chromium.org/2900703002 > Cr-Commit-Position: refs/heads/master@{#45479} > Committed: https://chromium.googlesource.com/v8/v8/+/e87573822e1c0c041c03f2b60599b0ab9256422f TBR=ishell@chromium.org,mlippautz@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6278, v8:6344, v8:6350 Review-Url: https://codereview.chromium.org/2903533002 Cr-Commit-Position: refs/heads/master@{#45483} Committed: https://chromium.googlesource.com/v8/v8/+/3d40a47a9de333cc7f1c7c6a6d4daea5658bc901

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -88 lines) Patch
M src/api.cc View 2 chunks +6 lines, -18 lines 0 comments Download
M src/builtins/arm/builtins-arm.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/builtins/builtins-symbol.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/builtins/builtins-symbol-gen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M src/factory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/factory.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M src/heap-symbols.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/heap.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M src/isolate.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/objects.h View 2 chunks +1 line, -6 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-symbol.cc View 4 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [es2015] Precompute the descriptive string for symbols.
3 years, 7 months ago (2017-05-23 11:57:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903533002/1
3 years, 7 months ago (2017-05-23 11:58:05 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 11:58:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/3d40a47a9de333cc7f1c7c6a6d4daea5658...

Powered by Google App Engine
This is Rietveld 408576698