Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: src/builtins/arm/builtins-arm.cc

Issue 2903533002: Revert of [es2015] Precompute the descriptive string for symbols. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/api.cc ('k') | src/builtins/arm64/builtins-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/assembler-inl.h" 7 #include "src/assembler-inl.h"
8 #include "src/codegen.h" 8 #include "src/codegen.h"
9 #include "src/counters.h" 9 #include "src/counters.h"
10 #include "src/debug/debug.h" 10 #include "src/debug/debug.h"
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 __ SmiTag(r2); 287 __ SmiTag(r2);
288 __ EnterBuiltinFrame(cp, r1, r2); 288 __ EnterBuiltinFrame(cp, r1, r2);
289 __ Call(masm->isolate()->builtins()->ToString(), RelocInfo::CODE_TARGET); 289 __ Call(masm->isolate()->builtins()->ToString(), RelocInfo::CODE_TARGET);
290 __ LeaveBuiltinFrame(cp, r1, r2); 290 __ LeaveBuiltinFrame(cp, r1, r2);
291 __ SmiUntag(r2); 291 __ SmiUntag(r2);
292 } 292 }
293 __ b(&drop_frame_and_ret); 293 __ b(&drop_frame_and_ret);
294 294
295 // 3b. Convert symbol in r0 to a string. 295 // 3b. Convert symbol in r0 to a string.
296 __ bind(&symbol_descriptive_string); 296 __ bind(&symbol_descriptive_string);
297 __ ldr(r0, FieldMemOperand(r0, Symbol::kDescriptiveStringOffset)); 297 {
298 // Fall through. 298 __ Drop(r2);
299 __ Drop(1);
300 __ Push(r0);
301 __ TailCallRuntime(Runtime::kSymbolDescriptiveString);
302 }
299 303
300 __ bind(&drop_frame_and_ret); 304 __ bind(&drop_frame_and_ret);
301 { 305 {
302 __ Drop(r2); 306 __ Drop(r2);
303 __ Ret(1); 307 __ Ret(1);
304 } 308 }
305 } 309 }
306 310
307 // static 311 // static
308 void Builtins::Generate_StringConstructor_ConstructStub(MacroAssembler* masm) { 312 void Builtins::Generate_StringConstructor_ConstructStub(MacroAssembler* masm) {
(...skipping 2740 matching lines...) Expand 10 before | Expand all | Expand 10 after
3049 } 3053 }
3050 // Now jump to the instructions of the returned code object. 3054 // Now jump to the instructions of the returned code object.
3051 __ Jump(r8); 3055 __ Jump(r8);
3052 } 3056 }
3053 #undef __ 3057 #undef __
3054 3058
3055 } // namespace internal 3059 } // namespace internal
3056 } // namespace v8 3060 } // namespace v8
3057 3061
3058 #endif // V8_TARGET_ARCH_ARM 3062 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/api.cc ('k') | src/builtins/arm64/builtins-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698