Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2903463002: Revert of Disable WebRtcVideoQualityBrowserTest.TestVideoQualityH264/0 on Win bots. (Closed)

Created:
3 years, 7 months ago by emircan
Modified:
3 years, 7 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, phoglund+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable WebRtcVideoQualityBrowserTest.TestVideoQualityH264/0 on Win bots. (patchset #2 id:20001 of https://codereview.chromium.org/2893523004/ ) Reason for revert: This test passes after the fixes on issue webrtc:7532. See the explanation https://bugs.chromium.org/p/chromium/issues/detail?id=722746#c21 for how they are related. Original issue's description: > Disable WebRtcVideoQualityBrowserTest.TestVideoQualityH264/0 on Win bots. > > BUG=chromium:722746 > > Review-Url: https://codereview.chromium.org/2893523004 > Cr-Commit-Position: refs/heads/master@{#472824} > Committed: https://chromium.googlesource.com/chromium/src/+/7498e9b31a8ed8fd1d1fac071916cf824e48e2c5 TBR=tommi@chromium.org,philipel@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:722746 Review-Url: https://codereview.chromium.org/2903463002 Cr-Commit-Position: refs/heads/master@{#473760} Committed: https://chromium.googlesource.com/chromium/src/+/7197acdffac9a256fb1eed080469b2f383b97897

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M chrome/browser/media/webrtc/webrtc_video_quality_browsertest.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
emircan
Created Revert of Disable WebRtcVideoQualityBrowserTest.TestVideoQualityH264/0 on Win bots.
3 years, 7 months ago (2017-05-22 23:32:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903463002/1
3 years, 7 months ago (2017-05-22 23:33:34 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 00:22:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7197acdffac9a256fb1eed080469...

Powered by Google App Engine
This is Rietveld 408576698