Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2893523004: Disable WebRtcVideoQualityBrowserTest.TestVideoQualityH264/0 on Win bots. (Closed)

Created:
3 years, 7 months ago by philipel2
Modified:
3 years, 7 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, phoglund+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable WebRtcVideoQualityBrowserTest.TestVideoQualityH264/0 on Win bots. BUG=chromium:722746 Review-Url: https://codereview.chromium.org/2893523004 Cr-Commit-Position: refs/heads/master@{#472824} Committed: https://chromium.googlesource.com/chromium/src/+/7498e9b31a8ed8fd1d1fac071916cf824e48e2c5

Patch Set 1 #

Total comments: 1

Patch Set 2 : Nit fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/media/webrtc/webrtc_video_quality_browsertest.cc View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
philipel2
Try number 2 :)
3 years, 7 months ago (2017-05-18 08:52:09 UTC) #2
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/2893523004/diff/1/chrome/browser/media/webrtc/webrtc_video_quality_browsertest.cc File chrome/browser/media/webrtc/webrtc_video_quality_browsertest.cc (right): https://codereview.chromium.org/2893523004/diff/1/chrome/browser/media/webrtc/webrtc_video_quality_browsertest.cc#newcode363 chrome/browser/media/webrtc/webrtc_video_quality_browsertest.cc:363: #define MAYBE_TestVideoQualityH264 DISABLED_TestVideoQualityH264 nit: we don't indent #defines.
3 years, 7 months ago (2017-05-18 11:45:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893523004/20001
3 years, 7 months ago (2017-05-18 11:55:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/448480)
3 years, 7 months ago (2017-05-18 13:28:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893523004/20001
3 years, 7 months ago (2017-05-18 15:33:55 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/7498e9b31a8ed8fd1d1fac071916cf824e48e2c5
3 years, 7 months ago (2017-05-18 15:40:36 UTC) #13
emircan
3 years, 7 months ago (2017-05-22 23:32:56 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2903463002/ by emircan@chromium.org.

The reason for reverting is: This test passes after the fixes on issue
webrtc:7532. See the explanation
https://bugs.chromium.org/p/chromium/issues/detail?id=722746#c21 for how they
are related. .

Powered by Google App Engine
This is Rietveld 408576698