Limit certificate error reports to running in official builds

Limit certificate error reports to running in official builds

Reporting is now disabled except in official builds, with a hook
that tests can set to fake being an official build.

BUG=721205
Review-Url: https://codereview.chromium.org/2903383002
Cr-Commit-Position: refs/heads/master@{#475146}
Committed: https://chromium.googlesource.com/chromium/src/+/0ca6aab85a0d76d88a9333ed2618546fc1565025

[estark, 2017-05-26 00:27:07]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 00:28:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 01:19:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 01:19:32]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[estark, 2017-05-26 01:33:04]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 01:34:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2017-05-26 04:43:14]

estark@chromium.org changed reviewers:
+ nparker@chromium.org

[estark, 2017-05-26 04:43:15]

nparker, PTAL? Thanks!

[commit-bot: I haz the power, 2017-05-26 05:11:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 05:11:55]

Dry run: This issue passed the CQ dry run.

[felt, 2017-05-26 06:35:48]

Description was changed from

==========
Limit certificate error reports to official builds and tests

BUG=721205
==========

to

==========
Limit certificate error reports to official builds and tests

BUG=721205
==========

[felt, 2017-05-26 06:35:58]

felt@chromium.org changed reviewers:
+ felt@chromium.org

[felt, 2017-05-26 06:35:58]

+benwells as FYI since he wanted to see this

[felt, 2017-05-26 06:36:09]

felt@chromium.org changed reviewers:
- felt@chromium.org

[Nathan Parker, 2017-05-26 21:34:08]

lgtm

The CL comment says "limit to official builds and tests" but actually it's
limiting it to running in official builds but not official tests.  ya?

Do you know what was happening to non-official builds' reports before?  Was
Google receiving them?  And... Do we want them?

https://codereview.chromium.org/2903383002/diff/20001/chrome/browser/ssl/cert...
File chrome/browser/ssl/cert_report_helper.cc (right):

https://codereview.chromium.org/2903383002/diff/20001/chrome/browser/ssl/cert...
chrome/browser/ssl/cert_report_helper.cc:162: bool is_official_build =
g_is_fake_official_build_for_testing;
I feel like there could be a better pattern than this, but I don't know what it
is.  This seems like the simplest.

[estark, 2017-05-26 21:43:10]

Description was changed from

==========
Limit certificate error reports to official builds and tests

BUG=721205
==========

to

==========
Limit certificate error reports to running in official builds

Reporting is now disabled except in official builds, with a hook
that tests can set to fake being an official build.

BUG=721205
==========

[estark, 2017-05-26 21:43:25]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2017-05-26 21:43:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 21:50:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495835005703520,
"parent_rev": "2fc1dbd022af829f80502a0babe6a259c69dad58", "commit_rev":
"0ca6aab85a0d76d88a9333ed2618546fc1565025"}

[commit-bot: I haz the power, 2017-05-26 21:50:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495835005703520,
"parent_rev": "2fc1dbd022af829f80502a0babe6a259c69dad58", "commit_rev":
"0ca6aab85a0d76d88a9333ed2618546fc1565025"}

[commit-bot: I haz the power, 2017-05-26 21:51:07]

Description was changed from

==========
Limit certificate error reports to running in official builds

Reporting is now disabled except in official builds, with a hook
that tests can set to fake being an official build.

BUG=721205
==========

to

==========
Limit certificate error reports to running in official builds

Reporting is now disabled except in official builds, with a hook
that tests can set to fake being an official build.

BUG=721205

Review-Url: https://codereview.chromium.org/2903383002
Cr-Commit-Position: refs/heads/master@{#475146}
Committed:
https://chromium.googlesource.com/chromium/src/+/0ca6aab85a0d76d88a9333ed2618...
==========

[commit-bot: I haz the power, 2017-05-26 21:51:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0ca6aab85a0d76d88a9333ed2618...