Limit certificate error reports to running in official builds

chrome/browser/ssl/cert_report_helper.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ssl/cert_report_helper.h"
 
 #include <utility>
 
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
@@ skipping 11 matching lines @@
 #include "components/security_interstitials/core/controller_client.h"
 #include "components/security_interstitials/core/metrics_helper.h"
 #include "components/strings/grit/components_strings.h"
 #include "components/variations/variations_associated_data.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/web_contents.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace {
 
+// Certificate reports are only sent from official builds, but this flag can be
+// set by tests.
+static bool g_is_fake_official_build_for_testing = false;
+
 // Returns a pointer to the Profile associated with |web_contents|.
 Profile* GetProfile(content::WebContents* web_contents) {
   return Profile::FromBrowserContext(web_contents->GetBrowserContext());
 }
 
 }  // namespace
 
 // Constants for the HTTPSErrorReporter Finch experiment
 const char CertReportHelper::kFinchExperimentName[] = "ReportCertificateErrors";
 const char CertReportHelper::kFinchGroupShowPossiblySend[] =
@@ skipping 16 matching lines @@
       request_url_(request_url),
       ssl_info_(ssl_info),
       interstitial_reason_(interstitial_reason),
       overridable_(overridable),
       interstitial_time_(interstitial_time),
       metrics_helper_(metrics_helper) {}
 
 CertReportHelper::~CertReportHelper() {
 }
 
+// static
+void CertReportHelper::SetFakeOfficialBuildForTesting() {
+  g_is_fake_official_build_for_testing = true;
+}
+
 void CertReportHelper::PopulateExtendedReportingOption(
     base::DictionaryValue* load_time_data) {
   // Only show the checkbox if not off-the-record and if this client is
   // part of the respective Finch group, and the feature is not disabled
   // by policy.
   const bool show = ShouldShowCertificateReporterCheckbox();
 
   load_time_data->SetBoolean(security_interstitials::kDisplayCheckBox, show);
   if (!show)
     return;
@@ skipping 64 matching lines @@
   const bool in_incognito =
       web_contents_->GetBrowserContext()->IsOffTheRecord();
   return base::FieldTrialList::FindFullName(kFinchExperimentName) ==
              kFinchGroupShowPossiblySend &&
          !in_incognito &&
          IsPrefEnabled(prefs::kSafeBrowsingExtendedReportingOptInAllowed);
 }
 
 bool CertReportHelper::ShouldReportCertificateError() {
   DCHECK(ShouldShowCertificateReporterCheckbox());
+
+  bool is_official_build = g_is_fake_official_build_for_testing;

[Nathan Parker, 2017/05/26 21:34:07]

I feel like there could be a better pattern than this, but I don't know what it
is.  This seems like the simplest.

+#if defined(OFFICIAL_BUILD) && defined(GOOGLE_CHROME_BUILD)
+  is_official_build = true;
+#endif
+
+  if (!is_official_build)
+    return false;
+
   // Even in case the checkbox was shown, we don't send error reports
   // for all of these users. Check the Finch configuration for a sending
   // threshold and only send reports in case the threshold isn't exceeded.
   const std::string param =
       variations::GetVariationParamValue(kFinchExperimentName, kFinchParamName);
   if (!param.empty()) {
     double sendingThreshold;
     if (base::StringToDouble(param, &sendingThreshold)) {
       if (sendingThreshold >= 0.0 && sendingThreshold <= 1.0)
         return base::RandDouble() <= sendingThreshold;
     }
   }
   return false;
 }
 
 bool CertReportHelper::IsPrefEnabled(const char* pref) {
   return GetProfile(web_contents_)->GetPrefs()->GetBoolean(pref);
 }