Issue 29033003: Fixing custom element type extensions in Dartium to have correct native type ID

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 29033003: Fixing custom element type extensions in Dartium to have correct native type ID (Closed)

Created:
7 years, 2 months ago by blois

Modified:
7 years, 2 months ago

Reviewers:
vsm, siva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fixing custom element type extensions in Dartium to have correct native type ID This is in support of the recent change to write the native type ID to the Dart wrappers Dart changes for https://codereview.chromium.org/27769002/ BUG=14190 R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=28899

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -5 lines)			Patch
M	sdk/lib/html/dartium/html_dartium.dart	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	tests/html/custom/document_register_type_extensions_test.dart	View		3 chunks	+30 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/systemnative.py	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	tools/dom/src/native_DOMImplementation.dart	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

blois

7 years, 2 months ago (2013-10-18 23:43:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r28899 (presubmit successful).