Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 29033003: Fixing custom element type extensions in Dartium to have correct native type ID (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | tests/html/custom/document_register_type_extensions_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index a5382551aad5bed0b99e20209300349b7b8b1a3f..98482b7163159d7c918d1f6b66021b112e0f02cd 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -35350,9 +35350,12 @@ class _Utils {
return false;
}
- static bool isTypeSubclassOfTag(Type type, String tagName) {
+ static Element getAndValidateNativeType(Type type, String tagName) {
var element = new Element.tag(tagName);
- return isTypeSubclassOf(type, element.runtimeType);
+ if (!isTypeSubclassOf(type, element.runtimeType)) {
+ return null;
+ }
+ return element;
}
static window() native "Utils_window";
« no previous file with comments | « no previous file | tests/html/custom/document_register_type_extensions_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698