tools/dom/scripts/systemnative.py - Issue 29033003: Fixing custom element type extensions in Dartium to have correct native type ID

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/systemnative.py

Issue 29033003: Fixing custom element type extensions in Dartium to have correct native type ID (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/dom/scripts/systemnative.py

diff --git a/tools/dom/scripts/systemnative.py b/tools/dom/scripts/systemnative.py

index a1b6ee03244ccd33c2fefb77349404071f26e0e7..c7f88a660909c2d8ae6bd6005ea855715f217d2d 100644

--- a/tools/dom/scripts/systemnative.py

+++ b/tools/dom/scripts/systemnative.py

@@ -1200,7 +1200,8 @@ class CPPLibraryEmitter():

e.Emit('namespace WebCore {\n');

e.Emit('\n');

e.Emit('enum {\n');

- e.Emit(' _HistoryCrossFrameClassId = 0,\n');

+ e.Emit(' _InvalidClassId = 0,\n');

+ e.Emit(' _HistoryCrossFrameClassId,\n');

e.Emit(' _LocationCrossFrameClassId,\n');

e.Emit(' _DOMWindowCrossFrameClassId,\n');

e.Emit(' _DateTimeClassId,\n');

@@ -1243,6 +1244,7 @@ class CPPLibraryEmitter():

e.Emit('namespace WebCore {\n');

e.Emit('\n');

e.Emit("_DartWebkitClassInfo DartWebkitClassInfo = {\n");

+ e.Emit(' { "_InvalidClassId", -1, -1, false, false, false },\n');

e.Emit(' { "_HistoryCrossFrame", DartHtmlLibraryId, -1, false, false, false },\n');

e.Emit(' { "_LocationCrossFrame", DartHtmlLibraryId, -1, false, false, false },\n');

e.Emit(' { "_DOMWindowCrossFrame", DartHtmlLibraryId, -1, false, false, true },\n');

« no previous file with comments | « tests/html/custom/document_register_type_extensions_test.dart ('k') | tools/dom/src/native_DOMImplementation.dart » ('j') | no next file with comments »