Do not use ScopedTaskEnvironment::RunUntilIdle() in URLRequestSimpleJobTest.

Do not use ScopedTaskEnvironment::RunUntilIdle() in URLRequestSimpleJobTest.

URLRequestSimpleJobTest.CancelAfterFirstReadStarted doesn't need
ScopedTaskEnvironment::RunUntilIdle() because it doesn't depend on
tasks running in TaskScheduler.

Moving from ScopedTaskEnvironment::RunUntilIdle() to
RunLoop::RunUntilIdle() in this test is important because the
test posts a MessageLoop::QuitWhenIdleClosure() (via TestDelegate),
which is incompatible with changes that we want to make to
ScopedTaskEnvironment::RunUntilIdle().

BUG=724077
Review-Url: https://codereview.chromium.org/2903213003
Cr-Commit-Position: refs/heads/master@{#474772}
Committed: https://chromium.googlesource.com/chromium/src/+/38ca4d86dba6022a465b9966e6917a9e004e919b

[fdoray, 2017-05-25 19:12:15]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 19:12:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-05-25 19:44:41]

fdoray@chromium.org changed reviewers:
+ mmenke@chromium.org

[fdoray, 2017-05-25 19:44:42]

Please take a look.

[mmenke, 2017-05-25 19:52:14]

On 2017/05/25 19:44:42, fdoray wrote:
> Please take a look.

LGTM.  I am a bit concerned that it will take a ScopedTaskEnvironment guru to
truly make sense of any of this - where RunLoops are necessary, where they cause
problems, and why, etc.

[fdoray, 2017-05-25 19:59:35]

On 2017/05/25 19:52:14, mmenke wrote:
> On 2017/05/25 19:44:42, fdoray wrote:
> > Please take a look.
> 
> LGTM.  I am a bit concerned that it will take a ScopedTaskEnvironment guru to
> truly make sense of any of this - where RunLoops are necessary, where they
cause
> problems, and why, etc.

https://chromium.googlesource.com/chromium/src/+/master/docs/threading_and_ta...
should help. We would like to add an exhaustive FAQ to the documentation to
answer any questions that people might have. To which questions would you like
to get answers?

[fdoray, 2017-05-25 19:59:39]

The CQ bit was unchecked by fdoray@chromium.org

[fdoray, 2017-05-25 19:59:48]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-05-25 20:00:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 20:06:55]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495742388050030, "parent_rev":
"df3c9bc828ab4781e1dc5b51a95feb004ca8bd39", "commit_rev":
"38ca4d86dba6022a465b9966e6917a9e004e919b"}

[commit-bot: I haz the power, 2017-05-25 20:07:04]

Description was changed from

==========
Do not use ScopedTaskEnvironment::RunUntilIdle() in URLRequestSimpleJobTest.

URLRequestSimpleJobTest.CancelAfterFirstReadStarted doesn't need
ScopedTaskEnvironment::RunUntilIdle() because it doesn't depend on
tasks running in TaskScheduler.

Moving from ScopedTaskEnvironment::RunUntilIdle() to
RunLoop::RunUntilIdle() in this test is important because the
test posts a MessageLoop::QuitWhenIdleClosure() (via TestDelegate),
which is incompatible with changes that we want to make to
ScopedTaskEnvironment::RunUntilIdle().

BUG=724077
==========

to

==========
Do not use ScopedTaskEnvironment::RunUntilIdle() in URLRequestSimpleJobTest.

URLRequestSimpleJobTest.CancelAfterFirstReadStarted doesn't need
ScopedTaskEnvironment::RunUntilIdle() because it doesn't depend on
tasks running in TaskScheduler.

Moving from ScopedTaskEnvironment::RunUntilIdle() to
RunLoop::RunUntilIdle() in this test is important because the
test posts a MessageLoop::QuitWhenIdleClosure() (via TestDelegate),
which is incompatible with changes that we want to make to
ScopedTaskEnvironment::RunUntilIdle().

BUG=724077

Review-Url: https://codereview.chromium.org/2903213003
Cr-Commit-Position: refs/heads/master@{#474772}
Committed:
https://chromium.googlesource.com/chromium/src/+/38ca4d86dba6022a465b9966e691...
==========

[commit-bot: I haz the power, 2017-05-25 20:07:05]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/38ca4d86dba6022a465b9966e691...