Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: net/url_request/url_request_simple_job_unittest.cc

Issue 2903213003: Do not use ScopedTaskEnvironment::RunUntilIdle() in URLRequestSimpleJobTest. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_simple_job_unittest.cc
diff --git a/net/url_request/url_request_simple_job_unittest.cc b/net/url_request/url_request_simple_job_unittest.cc
index 001cac922ec765d94c61e2b45c4d1e1271147f39..81e9588b3e16026928f172b38b9d60bdbd1bf389 100644
--- a/net/url_request/url_request_simple_job_unittest.cc
+++ b/net/url_request/url_request_simple_job_unittest.cc
@@ -14,10 +14,8 @@
#include "base/sequenced_task_runner.h"
#include "base/strings/string_piece.h"
#include "base/strings/stringprintf.h"
-#include "base/test/scoped_task_environment.h"
#include "net/base/request_priority.h"
#include "net/test/gtest_util.h"
-#include "net/test/net_test_suite.h"
#include "net/traffic_annotation/network_traffic_annotation_test_helper.h"
#include "net/url_request/url_request_job.h"
#include "net/url_request/url_request_job_factory.h"
@@ -219,9 +217,7 @@ TEST_F(URLRequestSimpleJobTest, CancelAfterFirstReadStarted) {
&cancel_delegate, TRAFFIC_ANNOTATION_FOR_TESTS);
request_->Start();
cancel_delegate.WaitUntilHeadersReceived();
-
- // Run TaskScheduler tasks and their reply on the main thread.
- NetTestSuite::GetScopedTaskEnvironment()->RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
EXPECT_THAT(cancel_delegate.request_status(), IsError(ERR_ABORTED));
EXPECT_EQ(1, cancel_delegate.response_started_count());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698