Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2903213002: Make a layer for popup MessageView (Closed)

Created:
3 years, 7 months ago by yoshiki
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Make a layer for popup MessageView Previously all MessageView had an own layer. And now, by http://crrev.com/2849523005, only non-popup MessageView, which is in the message center, has a layer. But it causes a regression (http://crbug.com/722647) so this CL reverts that part. This CL breaks swiping on popup but it'll be fixed soon by http://crrev.com/2873553002. BUG=722647 TEST=manual (issue doesn't happen) Review-Url: https://codereview.chromium.org/2880243003 Cr-Commit-Position: refs/heads/master@{#473838} (cherry picked from commit f98677dc227b94e8101184484eb0c8959218a508) Review-Url: https://codereview.chromium.org/2903213002 . Cr-Commit-Position: refs/branch-heads/3071@{#692} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/9fd4ce201b7b35eb228833bcee64e5a62c48b145

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ui/message_center/views/message_view.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
yoshiki
3 years, 7 months ago (2017-05-25 06:54:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9fd4ce201b7b35eb228833bcee64e5a62c48b145.

Powered by Google App Engine
This is Rietveld 408576698