Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2880243003:
Make a layer for popup MessageView (Closed)
DescriptionMake a layer for popup MessageView
Previously all MessageView had an own layer. And now, by http://crrev.com/2849523005, only non-popup MessageView, which is in the message center, has a layer.
But it causes a regression (http://crbug.com/722647) so this CL reverts that part.
This CL breaks swiping on popup but it'll be fixed soon by http://crrev.com/2873553002.
BUG=722647
TEST=manual (issue doesn't happen)
Review-Url: https://codereview.chromium.org/2880243003
Cr-Commit-Position: refs/heads/master@{#473838}
Committed: https://chromium.googlesource.com/chromium/src/+/f98677dc227b94e8101184484eb0c8959218a508
Patch Set 1 #
Total comments: 1
Patch Set 2 : Addressed comment #Messages
Total messages: 27 (18 generated)
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Description was changed from ========== wip BUG=722647 ========== to ========== Make a layer for popup MessageView Previously all MessageView had an own layer. And now, by http://crrev.com/2849523005, only non-popup MessageView, which is in the message center, has a layer. But it causes a regression (http://crbug.com/722647) so this CL reverts that part. This CL breaks swiping on popup but it'll be fixed soon by http://crrev.com/2873553002. BUG=722647 TEST=manual (issue doesn't happen) ==========
yoshiki@chromium.org changed reviewers: + edcourtney@chromium.org
Eliot, PTAL. Thanks.
lgtm https://codereview.chromium.org/2880243003/diff/1/ui/message_center/views/mes... File ui/message_center/views/message_view.cc (right): https://codereview.chromium.org/2880243003/diff/1/ui/message_center/views/mes... ui/message_center/views/message_view.cc:70: SetPaintToLayer(); Maybe add a comment as to why this has to be here?
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yoshiki@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from edcourtney@chromium.org Link to the patchset: https://codereview.chromium.org/2880243003/#ps20001 (title: "Addressed comment")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
yoshiki@chromium.org changed reviewers: + yhanada@chromium.org
Hanada-san, PTAL this? Thanks.
yoshiki@chromium.org changed reviewers: + fukino@chromium.org
Ah, I found Hanada-san is ooo today. Fukino-san, could you take a look as a committer? Thanks.
lgtm
The CQ bit was checked by yoshiki@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495528129427770,
"parent_rev": "54819c15bc373470597bb574895816174e633c72", "commit_rev":
"f98677dc227b94e8101184484eb0c8959218a508"}
Message was sent while issue was closed.
Description was changed from ========== Make a layer for popup MessageView Previously all MessageView had an own layer. And now, by http://crrev.com/2849523005, only non-popup MessageView, which is in the message center, has a layer. But it causes a regression (http://crbug.com/722647) so this CL reverts that part. This CL breaks swiping on popup but it'll be fixed soon by http://crrev.com/2873553002. BUG=722647 TEST=manual (issue doesn't happen) ========== to ========== Make a layer for popup MessageView Previously all MessageView had an own layer. And now, by http://crrev.com/2849523005, only non-popup MessageView, which is in the message center, has a layer. But it causes a regression (http://crbug.com/722647) so this CL reverts that part. This CL breaks swiping on popup but it'll be fixed soon by http://crrev.com/2873553002. BUG=722647 TEST=manual (issue doesn't happen) Review-Url: https://codereview.chromium.org/2880243003 Cr-Commit-Position: refs/heads/master@{#473838} Committed: https://chromium.googlesource.com/chromium/src/+/f98677dc227b94e8101184484eb0... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f98677dc227b94e8101184484eb0... |
